starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 11:50:30 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2230] [CLOSED] feat: Add autogroup ACLs #2559

New Issue
Closed
opened 2025-12-29 03:21:48 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:21:48 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2230
Author: @gabe565
Created: 11/8/2024
Status: ❌ Closed

Base: main ← Head: add-autogroups

📝 Commits (5)

  • 3ffae8a Add acl autogroup member and autogroup self
  • 2732e7a chore(policy): ACL code cleanups and lint fixes
  • dd528a1 chore(policy): Change expandAutoGroup into a receiver func
  • 2d1c52e test(policy): Add autogroup tests
  • fd038b9 chore: Update changelog

📊 Changes

3 files changed (+422 additions, -9 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 hscontrol/policy/acls.go (+166 -9)
📝 hscontrol/policy/acls_test.go (+255 -0)

📄 Description

I have taken @vinhjaxt's autogroup implementation from https://github.com/juanfont/headscale/issues/657#issuecomment-2336625885, added some code improvements, fixed lint, and added tests. This is still a WIP, but so far it's working as intended.

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Fixes #657

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2230 **Author:** [@gabe565](https://github.com/gabe565) **Created:** 11/8/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `add-autogroups` --- ### 📝 Commits (5) - [`3ffae8a`](https://github.com/juanfont/headscale/commit/3ffae8ac201dfa4ea8d824c2dfadac0d73cd57c6) Add acl autogroup member and autogroup self - [`2732e7a`](https://github.com/juanfont/headscale/commit/2732e7a017d114fe2887455e12507355fbdca93e) chore(policy): ACL code cleanups and lint fixes - [`dd528a1`](https://github.com/juanfont/headscale/commit/dd528a1753d4540cadee7ecc56687656c5ff66ca) chore(policy): Change `expandAutoGroup` into a receiver func - [`2d1c52e`](https://github.com/juanfont/headscale/commit/2d1c52ef1585c15a8d9fecb11194307b67c8281f) test(policy): Add autogroup tests - [`fd038b9`](https://github.com/juanfont/headscale/commit/fd038b9165d1b563c90f4420bcc1d98c6c54f0b5) chore: Update changelog ### 📊 Changes **3 files changed** (+422 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `hscontrol/policy/acls.go` (+166 -9) 📝 `hscontrol/policy/acls_test.go` (+255 -0) </details> ### 📄 Description <!-- Headscale is "Open Source, acknowledged contribution", this means that any contribution will have to be discussed with the Maintainers before being submitted. This model has been chosen to reduce the risk of burnout by limiting the maintenance overhead of reviewing and validating third-party code. Headscale is open to code contributions for bug fixes without discussion. If you find mistakes in the documentation, please submit a fix to the documentation. --> I have taken @vinhjaxt's autogroup implementation from https://github.com/juanfont/headscale/issues/657#issuecomment-2336625885, added some code improvements, fixed lint, and added tests. This is still a WIP, but so far it's working as intended. <!-- Please tick if the following things apply. You… --> - [x] have read the [CONTRIBUTING.md](./CONTRIBUTING.md) file - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [x] added unit tests - [x] added integration tests - [ ] updated documentation if needed - [x] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> Fixes #657 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:48 +01:00
adam closed this issue 2025-12-29 03:21:48 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2559
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?