starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 11:50:30 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2215] [CLOSED] wrap policy in a manager interface #2551

New Issue
Closed
opened 2025-12-29 03:21:46 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:21:46 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2215
Author: @kradalby
Created: 10/26/2024
Status: ❌ Closed

Base: main ← Head: kradalby/policy-manager-inf2

📝 Commits (10+)

  • 50165ce resolve user identifier to stable ID
  • 6afb554 wrap policy in policy manager interface
  • 8ecba12 remove unused args
  • 19bc8b6 report if filter has changed
  • 8d5b04f hook up user and node changes to policy
  • 50b62dd fix loading policy manager
  • f2ab5e0 split out reading policy and applying
  • 7f66502 fix nil pointer in oidc for policy
  • dbf2faa fix nil in router
  • 85a038c tags approved via acl

📊 Changes

18 files changed (+1041 additions, -355 deletions)

View changed files

📝 .github/workflows/test-integration.yaml (+1 -2)
📝 hscontrol/app.go (+115 -48)
📝 hscontrol/auth.go (+7 -0)
📝 hscontrol/db/node_test.go (+12 -7)
📝 hscontrol/db/routes.go (+5 -10)
📝 hscontrol/grpcv1.go (+26 -20)
📝 hscontrol/mapper/mapper.go (+19 -28)
📝 hscontrol/mapper/mapper_test.go (+12 -7)
📝 hscontrol/mapper/tail.go (+4 -4)
📝 hscontrol/mapper/tail_test.go (+3 -2)
📝 hscontrol/oidc.go (+14 -0)
📝 hscontrol/policy/acls.go (+73 -19)
📝 hscontrol/policy/acls_test.go (+327 -100)
➕ hscontrol/policy/pm.go (+181 -0)
➕ hscontrol/policy/pm_test.go (+158 -0)
📝 hscontrol/poll.go (+11 -8)
📝 integration/cli_test.go (+69 -100)
📝 integration/hsic/hsic.go (+4 -0)

📄 Description

test, depends on #2205

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2215 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 10/26/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `kradalby/policy-manager-inf2` --- ### 📝 Commits (10+) - [`50165ce`](https://github.com/juanfont/headscale/commit/50165ce9e1746303a14790fe0b6e9222ca455942) resolve user identifier to stable ID - [`6afb554`](https://github.com/juanfont/headscale/commit/6afb554e20cb06ed535ce9abd29a7abbdb8a72e4) wrap policy in policy manager interface - [`8ecba12`](https://github.com/juanfont/headscale/commit/8ecba121cc3b25a2c45718652cd67914ac41755d) remove unused args - [`19bc8b6`](https://github.com/juanfont/headscale/commit/19bc8b6e01cf4bd690fd29752e6c0bbf5bdd9060) report if filter has changed - [`8d5b04f`](https://github.com/juanfont/headscale/commit/8d5b04f3d3ec6694c3f6a21c70ff966f174dc1f3) hook up user and node changes to policy - [`50b62dd`](https://github.com/juanfont/headscale/commit/50b62ddfb3b81755e42b0fbb12b8b09cca8a2535) fix loading policy manager - [`f2ab5e0`](https://github.com/juanfont/headscale/commit/f2ab5e05c91a5b7ada10250504c363eddfeb55da) split out reading policy and applying - [`7f66502`](https://github.com/juanfont/headscale/commit/7f665023d82fd74984486a6872d2e679dc609521) fix nil pointer in oidc for policy - [`dbf2faa`](https://github.com/juanfont/headscale/commit/dbf2faa4bf55410c530ec2eb2cc8fc0728d67a49) fix nil in router - [`85a038c`](https://github.com/juanfont/headscale/commit/85a038cfcac932047abd8665d2d5173fdd4e59d0) tags approved via acl ### 📊 Changes **18 files changed** (+1041 additions, -355 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test-integration.yaml` (+1 -2) 📝 `hscontrol/app.go` (+115 -48) 📝 `hscontrol/auth.go` (+7 -0) 📝 `hscontrol/db/node_test.go` (+12 -7) 📝 `hscontrol/db/routes.go` (+5 -10) 📝 `hscontrol/grpcv1.go` (+26 -20) 📝 `hscontrol/mapper/mapper.go` (+19 -28) 📝 `hscontrol/mapper/mapper_test.go` (+12 -7) 📝 `hscontrol/mapper/tail.go` (+4 -4) 📝 `hscontrol/mapper/tail_test.go` (+3 -2) 📝 `hscontrol/oidc.go` (+14 -0) 📝 `hscontrol/policy/acls.go` (+73 -19) 📝 `hscontrol/policy/acls_test.go` (+327 -100) ➕ `hscontrol/policy/pm.go` (+181 -0) ➕ `hscontrol/policy/pm_test.go` (+158 -0) 📝 `hscontrol/poll.go` (+11 -8) 📝 `integration/cli_test.go` (+69 -100) 📝 `integration/hsic/hsic.go` (+4 -0) </details> ### 📄 Description test, depends on #2205 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:46 +01:00
adam closed this issue 2025-12-29 03:21:46 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2551
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?