starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 11:50:30 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2198] [MERGED] #2177 Added conversion of 'Hostname' to 'givenName' in a node with FQDN rules applied #2542

New Issue
Closed
opened 2025-12-29 03:21:43 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:21:43 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2198
Author: @hopleus
Created: 10/15/2024
Status: ✅ Merged
Merged: 10/15/2024
Merged by: @kradalby

Base: main ← Head: hotfix/2177-fqdn-givenname

📝 Commits (1)

  • c46fa24 #2177 Added conversion of 'Hostname' to 'givenName' in a node with FQDN rules applied

📊 Changes

5 files changed (+64 additions, -0 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 hscontrol/db/node.go (+1 -0)
📝 hscontrol/db/node_test.go (+9 -0)
📝 hscontrol/util/dns.go (+7 -0)
📝 hscontrol/util/dns_test.go (+46 -0)

📄 Description

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Fixes #2177

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2198 **Author:** [@hopleus](https://github.com/hopleus) **Created:** 10/15/2024 **Status:** ✅ Merged **Merged:** 10/15/2024 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `hotfix/2177-fqdn-givenname` --- ### 📝 Commits (1) - [`c46fa24`](https://github.com/juanfont/headscale/commit/c46fa24e01a07d308c86bfa3d4d6832d2abca5df) #2177 Added conversion of 'Hostname' to 'givenName' in a node with FQDN rules applied ### 📊 Changes **5 files changed** (+64 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `hscontrol/db/node.go` (+1 -0) 📝 `hscontrol/db/node_test.go` (+9 -0) 📝 `hscontrol/util/dns.go` (+7 -0) 📝 `hscontrol/util/dns_test.go` (+46 -0) </details> ### 📄 Description - [x] have read the [CONTRIBUTING.md](./CONTRIBUTING.md) file - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [x] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [x] updated CHANGELOG.md Fixes #2177 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:43 +01:00
adam closed this issue 2025-12-29 03:21:43 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2542
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?