starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 11:50:30 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2167] [MERGED] make reauth test compat with tailscale head #2534

New Issue
Closed
opened 2025-12-29 03:21:41 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:21:41 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2167
Author: @kradalby
Created: 10/3/2024
Status: ✅ Merged
Merged: 10/3/2024
Merged by: @kradalby

Base: main ← Head: kradalby/2164-reauth-test

📝 Commits (2)

  • 86e2770 make reauth test compat with tailscale head
  • 2b27fd0 sort test for stable order

📊 Changes

2 files changed (+106 additions, -80 deletions)

View changed files

📝 hscontrol/db/preauth_keys_test.go (+4 -1)
📝 integration/general_test.go (+102 -79)

📄 Description

tailscale/tailscale@1eaad7d broke our reauth test as it makes the client retry with https/443 if it reconnects within 2 minutes.

This commit fixes this by running the test as a two part,

  • with https, to confirm instant reconnect works
  • with http, and a 3 min wait, to check that it work without.

The change is not a general consern as headscale in prod is ran with https.

Updates #2164

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2167 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 10/3/2024 **Status:** ✅ Merged **Merged:** 10/3/2024 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/2164-reauth-test` --- ### 📝 Commits (2) - [`86e2770`](https://github.com/juanfont/headscale/commit/86e277003160f03dbf1548fbb88284fe9286c8b3) make reauth test compat with tailscale head - [`2b27fd0`](https://github.com/juanfont/headscale/commit/2b27fd0ec4fc831a809f8fd9b9fa730586b08b41) sort test for stable order ### 📊 Changes **2 files changed** (+106 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/db/preauth_keys_test.go` (+4 -1) 📝 `integration/general_test.go` (+102 -79) </details> ### 📄 Description tailscale/tailscale@1eaad7d broke our reauth test as it makes the client retry with https/443 if it reconnects within 2 minutes. This commit fixes this by running the test as a two part, - with https, to confirm instant reconnect works - with http, and a 3 min wait, to check that it work without. The change is not a general consern as headscale in prod is ran with https. Updates #2164 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:41 +01:00
adam closed this issue 2025-12-29 03:21:41 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2534
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?