starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2148] [MERGED] Add -it to docker exec #2523

New Issue
Closed
opened 2025-12-29 03:21:38 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:21:38 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2148
Author: @nblock
Created: 9/23/2024
Status: ✅ Merged
Merged: 9/25/2024
Merged by: @kradalby

Base: main ← Head: docker-it

📝 Commits (1)

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 docs/running-headscale-container.md (+4 -4)

📄 Description

Some commands such as nodes delete require user interaction and they fail if -it is no supplied to docker exec. Use docker exec -it in documentation examples to also make them work in interactive commands.

See: #2147

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2148 **Author:** [@nblock](https://github.com/nblock) **Created:** 9/23/2024 **Status:** ✅ Merged **Merged:** 9/25/2024 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `docker-it` --- ### 📝 Commits (1) - [`214ab40`](https://github.com/juanfont/headscale/commit/214ab40554395f3ea57d7cdaf58ec68e0b9be903) Add -it to docker exec ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `docs/running-headscale-container.md` (+4 -4) </details> ### 📄 Description Some commands such as `nodes delete` require user interaction and they fail if `-it` is no supplied to `docker exec`. Use `docker exec -it` in documentation examples to also make them work in interactive commands. See: #2147 - [x] have read the [CONTRIBUTING.md](./CONTRIBUTING.md) file - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [x] updated documentation if needed - [ ] updated CHANGELOG.md --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:38 +01:00
adam closed this issue 2025-12-29 03:21:38 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2523
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?