[PR #2134] [MERGED] Update headscale user creation settings in .deb #2519

Closed
opened 2025-12-29 03:21:37 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2134
Author: @jyundt
Created: 9/14/2024
Status: Merged
Merged: 9/29/2024
Merged by: @kradalby

Base: mainHead: change-default-headscale-shell


📝 Commits (3)

  • 487920b Update headscale user creation settings in .deb
  • 8bfdee9 slight refactor to use existing variables.
  • 443383e Fixup for HOME_DIR var

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 docs/packaging/postinstall.sh (+3 -1)

📄 Description

Update the headscale user settings to:

  • shell = /usr/sbin/nologin
  • home-dir = /var/lib/headscale

This syncs the .deb installation behavior with the current Linux docs: fe68f50328/docs/running-headscale-linux-manual.md (L39-L45)

Fixes juanfont/headscale#2133

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features
    • Enhanced security by modifying user creation parameters, preventing interactive logins for the headscale user.
    • Specified a dedicated home directory for the headscale user.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2134 **Author:** [@jyundt](https://github.com/jyundt) **Created:** 9/14/2024 **Status:** ✅ Merged **Merged:** 9/29/2024 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `change-default-headscale-shell` --- ### 📝 Commits (3) - [`487920b`](https://github.com/juanfont/headscale/commit/487920b7dfb37e5d9e3c60d7753e86bb66882ef1) Update headscale user creation settings in .deb - [`8bfdee9`](https://github.com/juanfont/headscale/commit/8bfdee97d4a35f35e233a7f0bbcf89c8b69843e5) slight refactor to use existing variables. - [`443383e`](https://github.com/juanfont/headscale/commit/443383e2904b07a36bc5b9bacfc3577aab6eea0b) Fixup for HOME_DIR var ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `docs/packaging/postinstall.sh` (+3 -1) </details> ### 📄 Description Update the headscale user settings to: - shell = /usr/sbin/nologin - home-dir = /var/lib/headscale This syncs the .deb installation behavior with the current Linux docs: https://github.com/juanfont/headscale/blob/fe68f503289db6cb1c2a568b8ae02a45ac632dd6/docs/running-headscale-linux-manual.md?plain=1#L39-L45 Fixes juanfont/headscale#2133 <!-- Headscale is "Open Source, acknowledged contribution", this means that any contribution will have to be discussed with the Maintainers before being submitted. This model has been chosen to reduce the risk of burnout by limiting the maintenance overhead of reviewing and validating third-party code. Headscale is open to code contributions for bug fixes without discussion. If you find mistakes in the documentation, please submit a fix to the documentation. --> <!-- Please tick if the following things apply. You… --> - [x] have read the [CONTRIBUTING.md](./CONTRIBUTING.md) file - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Enhanced security by modifying user creation parameters, preventing interactive logins for the headscale user. - Specified a dedicated home directory for the headscale user. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:37 +01:00
adam closed this issue 2025-12-29 03:21:37 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2519