starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 11:50:30 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2126] [MERGED] add shutdown that asserts if headscale had panics #2514

New Issue
Closed
opened 2025-12-29 03:21:36 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:21:36 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2126
Author: @kradalby
Created: 9/11/2024
Status: ✅ Merged
Merged: 9/17/2024
Merged by: @kradalby

Base: main ← Head: kradalby/check-for-panic

📝 Commits (1)

  • b9c448f check for panics after all tests

📊 Changes

10 files changed (+53 additions, -53 deletions)

View changed files

📝 integration/acl_test.go (+8 -8)
📝 integration/auth_oidc_test.go (+2 -2)
📝 integration/auth_web_flow_test.go (+2 -2)
📝 integration/cli_test.go (+15 -15)
📝 integration/dns_test.go (+2 -2)
📝 integration/embedded_derp_test.go (+1 -1)
📝 integration/general_test.go (+10 -10)
📝 integration/route_test.go (+5 -5)
📝 integration/scenario_test.go (+3 -3)
📝 integration/ssh_test.go (+5 -5)

📄 Description

Depends on #2125

Summary by CodeRabbit

  • Bug Fixes

    • Enhanced error handling during test shutdown processes to ensure no panics occur, improving test robustness across multiple test files.

  • Chores

    • Standardised the shutdown mechanism in tests by replacing scenario.Shutdown() with scenario.ShutdownAssertNoPanics(t) for better error reporting.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2126 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 9/11/2024 **Status:** ✅ Merged **Merged:** 9/17/2024 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/check-for-panic` --- ### 📝 Commits (1) - [`b9c448f`](https://github.com/juanfont/headscale/commit/b9c448f3d60951c623786b2c4feaeb8f4c28e3e1) check for panics after all tests ### 📊 Changes **10 files changed** (+53 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `integration/acl_test.go` (+8 -8) 📝 `integration/auth_oidc_test.go` (+2 -2) 📝 `integration/auth_web_flow_test.go` (+2 -2) 📝 `integration/cli_test.go` (+15 -15) 📝 `integration/dns_test.go` (+2 -2) 📝 `integration/embedded_derp_test.go` (+1 -1) 📝 `integration/general_test.go` (+10 -10) 📝 `integration/route_test.go` (+5 -5) 📝 `integration/scenario_test.go` (+3 -3) 📝 `integration/ssh_test.go` (+5 -5) </details> ### 📄 Description Depends on #2125 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Enhanced error handling during test shutdown processes to ensure no panics occur, improving test robustness across multiple test files. - **Chores** - Standardised the shutdown mechanism in tests by replacing `scenario.Shutdown()` with `scenario.ShutdownAssertNoPanics(t)` for better error reporting. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:36 +01:00
adam closed this issue 2025-12-29 03:21:36 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2514
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?