starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2102] [MERGED] Add support for service reload and sync service file #2497

New Issue
Closed
opened 2025-12-29 03:21:32 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:21:32 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2102
Author: @nblock
Created: 9/4/2024
Status: ✅ Merged
Merged: 9/5/2024
Merged by: @kradalby

Base: main ← Head: systemd-service

📝 Commits (3)

  • 445c1ca Add support for service reload and sync service file
  • 7d3a43e Its called systemd
  • 9337907 Fix link to systemd homepage

📊 Changes

4 files changed (+11 additions, -38 deletions)

View changed files

📝 docs/packaging/headscale.systemd.service (+1 -0)
📝 docs/running-headscale-linux-manual.md (+8 -36)
📝 docs/running-headscale-linux.md (+1 -1)
📝 integration/dns_test.go (+1 -1)

📄 Description

  • Copy the systemd.service file to the manual linux docs and adjust the path to the headscale binary to match with the previous documentation blocks. Unfortunately, there seems to be no easy way to include a file in mkdocs.
  • Remove a redundant "deprecation" block. The beginning of the documentation already states that.
  • Add ExecReload to the systemd.service file.

Fixes #2016

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Summary by CodeRabbit

  • New Features

    • Enhanced service management with the addition of the ExecReload directive for graceful configuration reloads.

  • Documentation

    • Streamlined instructions for running headscale on Linux, encouraging the use of pre-packaged service files.
    • Corrected references from "SystemD" to "systemd" for consistency and accuracy in documentation.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2102 **Author:** [@nblock](https://github.com/nblock) **Created:** 9/4/2024 **Status:** ✅ Merged **Merged:** 9/5/2024 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `systemd-service` --- ### 📝 Commits (3) - [`445c1ca`](https://github.com/juanfont/headscale/commit/445c1cac3c3472d7acb9248e0048850de4521d8c) Add support for service reload and sync service file - [`7d3a43e`](https://github.com/juanfont/headscale/commit/7d3a43e512a047a0dea0d4457ab58ed77c3750b4) Its called systemd - [`9337907`](https://github.com/juanfont/headscale/commit/9337907b60b42e76cc0e39c9b84071e98921c7a2) Fix link to systemd homepage ### 📊 Changes **4 files changed** (+11 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `docs/packaging/headscale.systemd.service` (+1 -0) 📝 `docs/running-headscale-linux-manual.md` (+8 -36) 📝 `docs/running-headscale-linux.md` (+1 -1) 📝 `integration/dns_test.go` (+1 -1) </details> ### 📄 Description * Copy the systemd.service file to the manual linux docs and adjust the path to the headscale binary to match with the previous documentation blocks. Unfortunately, there seems to be no easy way to include a file in mkdocs. * Remove a redundant "deprecation" block. The beginning of the documentation already states that. * Add `ExecReload` to the systemd.service file. Fixes #2016 - [x] have read the [CONTRIBUTING.md](./CONTRIBUTING.md) file - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [x] updated documentation if needed - [ ] updated CHANGELOG.md <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced service management with the addition of the `ExecReload` directive for graceful configuration reloads. - **Documentation** - Streamlined instructions for running `headscale` on Linux, encouraging the use of pre-packaged service files. - Corrected references from "SystemD" to "systemd" for consistency and accuracy in documentation. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:32 +01:00
adam closed this issue 2025-12-29 03:21:32 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2497
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?