starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-03-08 06:10:04 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2075] [MERGED] fix warning errs from beta2 #2478

New Issue
Closed
opened 2025-12-29 03:21:27 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:21:27 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2075
Author: @kradalby
Created: 8/23/2024
Status: ✅ Merged
Merged: 8/23/2024
Merged by: @kradalby

Base: main ← Head: kradalby/beta2-fixes

📝 Commits (2)

  • ac72050 remove default false for use usernames causing warning
  • 1b86535 Ensure DoH warnings are only emitted if err

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 hscontrol/types/config.go (+4 -1)

📄 Description

Fixes #2065
Fixes #2064

Summary by CodeRabbit

  • New Features
    • Enhanced configuration loading process for DNS settings, improving initialisation for user-specific configurations.
    • Improved handling of DNS resolver entries, streamlining control flow and reducing the risk of errors.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2075 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 8/23/2024 **Status:** ✅ Merged **Merged:** 8/23/2024 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/beta2-fixes` --- ### 📝 Commits (2) - [`ac72050`](https://github.com/juanfont/headscale/commit/ac720509219ade2846ee7a9afca7ca7d0c27cdb9) remove default false for use usernames causing warning - [`1b86535`](https://github.com/juanfont/headscale/commit/1b8653570f7ea91d86568c799a29df4ba955f3a3) Ensure DoH warnings are only emitted if err ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/types/config.go` (+4 -1) </details> ### 📄 Description Fixes #2065 Fixes #2064 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced configuration loading process for DNS settings, improving initialisation for user-specific configurations. - Improved handling of DNS resolver entries, streamlining control flow and reducing the risk of errors. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:27 +01:00
adam closed this issue 2025-12-29 03:21:27 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2478
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?