[PR #2058] [CLOSED] build docker images on PR #2472

Closed
opened 2025-12-29 03:21:26 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2058
Author: @kradalby
Created: 8/13/2024
Status: Closed

Base: mainHead: kradalby/build-docker-on-pr


📝 Commits (10+)

📊 Changes

4 files changed (+112 additions, -37 deletions)

View changed files

.github/workflows/build-docker-pr.yml (+71 -0)
📝 .github/workflows/build.yml (+25 -35)
📝 .goreleaser.yml (+0 -2)
.ko.yaml (+16 -0)

📄 Description

Take 2, not from fork, supersedes #2053

Sometimes we want people to test features in PRs and
not everyone is used to using git, build go and docker.

This commit builds docker containers and pushes them to
GHCR (not dockerhub) for testing on pushes to branches
that has open pull requests to main using Ko.
This is configured to mimic the debug images produced
by goreleaser.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2058 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 8/13/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `kradalby/build-docker-on-pr` --- ### 📝 Commits (10+) - [`cec4671`](https://github.com/juanfont/headscale/commit/cec46716b6ccf5c1e89b8ddcd7532aa463d9b242) build docker images on PR - [`e1416a7`](https://github.com/juanfont/headscale/commit/e1416a72cb21a173a3e3ac618e449e31cc07e611) make it so ko.yaml changes trigger build - [`0d6a25d`](https://github.com/juanfont/headscale/commit/0d6a25d6ee2ff3d20f74f00af11c3f89df011b03) env it - [`6866923`](https://github.com/juanfont/headscale/commit/68669238f952b99609aa4ece541a0795d0881312) debug pr name - [`52cce46`](https://github.com/juanfont/headscale/commit/52cce46cd876e77a386dc32ece03fdad042a8583) debug pr number - [`53a08e5`](https://github.com/juanfont/headscale/commit/53a08e5ab6c223ee169d68fb91f770e1a0d2661f) derp - [`49952dd`](https://github.com/juanfont/headscale/commit/49952dda401112bf796deab5aa4f5857a7be5d90) derp - [`1efb817`](https://github.com/juanfont/headscale/commit/1efb817acc0001e065f466861aab33cea4ff47b7) all - [`aba61ce`](https://github.com/juanfont/headscale/commit/aba61ceb1b147611306feb200f7a8d27fe4e0cfb) test without pr number - [`9a4c7e4`](https://github.com/juanfont/headscale/commit/9a4c7e444641164f73581a4659d587694c124627) run ko with nix ### 📊 Changes **4 files changed** (+112 additions, -37 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/build-docker-pr.yml` (+71 -0) 📝 `.github/workflows/build.yml` (+25 -35) 📝 `.goreleaser.yml` (+0 -2) ➕ `.ko.yaml` (+16 -0) </details> ### 📄 Description Take 2, not from fork, supersedes #2053 Sometimes we want people to test features in PRs and not everyone is used to using git, build go and docker. This commit builds docker containers and pushes them to GHCR (not dockerhub) for testing on pushes to branches that has open pull requests to main using Ko. This is configured to mimic the debug images produced by goreleaser. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:26 +01:00
adam closed this issue 2025-12-29 03:21:26 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2472