starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2057] [CLOSED] Don't overwrite previously filled dnsConfig.Domains #2471

New Issue
Closed
opened 2025-12-29 03:21:26 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:21:26 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2057
Author: @SuperSandro2000
Created: 8/13/2024
Status: ❌ Closed

Base: main ← Head: 1936-misc

📝 Commits (1)

  • 8b3af45 Don't overwrite previously filled dnsConfig.Domains

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 hscontrol/types/config.go (+1 -1)

📄 Description

Before we threw away the value from 8b3af45091/hscontrol/types/config.go (L561)

I am not sure if this was more correct. If so, we should drop the domains code in the loop.

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2057 **Author:** [@SuperSandro2000](https://github.com/SuperSandro2000) **Created:** 8/13/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `1936-misc` --- ### 📝 Commits (1) - [`8b3af45`](https://github.com/juanfont/headscale/commit/8b3af45091b07169699c7879f3e050e312e42cf1) Don't overwrite previously filled dnsConfig.Domains ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/types/config.go` (+1 -1) </details> ### 📄 Description Before we threw away the value from https://github.com/juanfont/headscale/blob/8b3af45091b07169699c7879f3e050e312e42cf1/hscontrol/types/config.go#L561 I am not sure if this was more correct. If so, we should drop the domains code in the loop. <!-- Please tick if the following things apply. You… --> - [x] have read the [CONTRIBUTING.md](./CONTRIBUTING.md) file - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:26 +01:00
adam closed this issue 2025-12-29 03:21:26 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2471
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?