starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2041] [MERGED] make acl_policy_path fatal if policy.path is not set #2464

New Issue
Closed
opened 2025-12-29 03:21:23 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:21:23 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2041
Author: @kradalby
Created: 8/2/2024
Status: ✅ Merged
Merged: 8/19/2024
Merged by: @kradalby

Base: main ← Head: kradalby/policy-path

📝 Commits (1)

  • 6a4546e make acl_policy_path fatal if policy.path is not set

📊 Changes

6 files changed (+42 additions, -5 deletions)

View changed files

📝 config-example.yaml (+2 -2)
📝 hscontrol/types/config.go (+1 -1)
📝 hscontrol/types/config_test.go (+19 -0)
➕ hscontrol/types/testdata/policy-path-is-loaded.yaml (+18 -0)
📝 integration/hsic/config.go (+1 -1)
📝 integration/hsic/hsic.go (+1 -1)

📄 Description

this commit changes and streamlines the dns_config into a new
key, dns. It removes a combination of outdates and incompatible
configuration options that made it easy to confuse what headscale
could and could not do, or what to expect from ones configuration.

It has to go in after #2034 with a rebase as it contains that commit because of
some helpers used there.

Fixes #2024

Signed-off-by: Kristoffer Dalby kristoffer@tailscale.com

Summary by CodeRabbit

  • New Features

    • Introduced a new configuration file to manage network policies and database settings, enhancing overall system capabilities.
    • Updated DNS settings in the configuration to improve clarity and accuracy.

  • Bug Fixes

    • Corrected typographical errors in the configuration documentation, improving user understanding.

  • Tests

    • Added a new test case to ensure proper loading of configuration files and validation of policy settings.

  • Chores

    • Renamed ACL policy path key for better clarity and consistency in configuration management.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2041 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 8/2/2024 **Status:** ✅ Merged **Merged:** 8/19/2024 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/policy-path` --- ### 📝 Commits (1) - [`6a4546e`](https://github.com/juanfont/headscale/commit/6a4546edc79f4ae3985f6e9e39a4687238048156) make acl_policy_path fatal if policy.path is not set ### 📊 Changes **6 files changed** (+42 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `config-example.yaml` (+2 -2) 📝 `hscontrol/types/config.go` (+1 -1) 📝 `hscontrol/types/config_test.go` (+19 -0) ➕ `hscontrol/types/testdata/policy-path-is-loaded.yaml` (+18 -0) 📝 `integration/hsic/config.go` (+1 -1) 📝 `integration/hsic/hsic.go` (+1 -1) </details> ### 📄 Description this commit changes and streamlines the dns_config into a new key, dns. It removes a combination of outdates and incompatible configuration options that made it easy to confuse what headscale could and could not do, or what to expect from ones configuration. It has to go in after #2034 with a rebase as it contains that commit because of some helpers used there. Fixes #2024 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new configuration file to manage network policies and database settings, enhancing overall system capabilities. - Updated DNS settings in the configuration to improve clarity and accuracy. - **Bug Fixes** - Corrected typographical errors in the configuration documentation, improving user understanding. - **Tests** - Added a new test case to ensure proper loading of configuration files and validation of policy settings. - **Chores** - Renamed ACL policy path key for better clarity and consistency in configuration management. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:23 +01:00
adam closed this issue 2025-12-29 03:21:23 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2464
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?