starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 11:50:30 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1959] [MERGED] remove last_successful_update error check #2424

New Issue
Closed
opened 2025-12-29 03:21:13 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:21:13 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1959
Author: @kradalby
Created: 5/27/2024
Status: ✅ Merged
Merged: 5/27/2024
Merged by: @kradalby

Base: main ← Head: kradalby/1956-postgres-migration

📝 Commits (1)

  • c2f4075 remove last_successful_update, ignore error

📊 Changes

1 file changed (+3 additions, -9 deletions)

View changed files

📝 hscontrol/db/db.go (+3 -9)

📄 Description

most of the time we dont even check this error and checking the string for particular errors is very flake as different databases (sqlite and psql) use different error messages, and some users might have it in other languages.

Fixes #1956

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1959 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 5/27/2024 **Status:** ✅ Merged **Merged:** 5/27/2024 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/1956-postgres-migration` --- ### 📝 Commits (1) - [`c2f4075`](https://github.com/juanfont/headscale/commit/c2f40755a6fc8477449773fd56ca8f8f9c075317) remove last_successful_update, ignore error ### 📊 Changes **1 file changed** (+3 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/db/db.go` (+3 -9) </details> ### 📄 Description most of the time we dont even check this error and checking the string for particular errors is very flake as different databases (sqlite and psql) use different error messages, and some users might have it in other languages. Fixes #1956 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:13 +01:00
adam closed this issue 2025-12-29 03:21:13 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2424
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?