[PR #1939] [MERGED] Initialize log config earlier to prevent trace messages being printed early on #2409

Closed
opened 2025-12-29 03:21:06 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1939
Author: @SuperSandro2000
Created: 5/14/2024
Status: Merged
Merged: 5/16/2024
Merged by: @kradalby

Base: mainHead: log-trace


📝 Commits (1)

  • 973e9cf Initialize log config earlier to prevent trace messages being printed early on

📊 Changes

2 files changed (+6 additions, -5 deletions)

View changed files

📝 cmd/headscale/cli/root.go (+0 -2)
📝 hscontrol/types/config.go (+6 -3)

📄 Description

like TRC DNS configuration loaded dns_config={....}

Closes #1576

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1939 **Author:** [@SuperSandro2000](https://github.com/SuperSandro2000) **Created:** 5/14/2024 **Status:** ✅ Merged **Merged:** 5/16/2024 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `log-trace` --- ### 📝 Commits (1) - [`973e9cf`](https://github.com/juanfont/headscale/commit/973e9cf45858129d169ef9b093125113fb9c107c) Initialize log config earlier to prevent trace messages being printed early on ### 📊 Changes **2 files changed** (+6 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `cmd/headscale/cli/root.go` (+0 -2) 📝 `hscontrol/types/config.go` (+6 -3) </details> ### 📄 Description like TRC DNS configuration loaded dns_config={....} Closes #1576 - [x] have read the [CONTRIBUTING.md](./CONTRIBUTING.md) file - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:06 +01:00
adam closed this issue 2025-12-29 03:21:06 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2409