starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1912] [MERGED] Do not access node ID when node is not found #2393

New Issue
Closed
opened 2025-12-29 03:21:02 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:21:02 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1912
Author: @juanfont
Created: 4/23/2024
Status: ✅ Merged
Merged: 4/24/2024
Merged by: @kradalby

Base: main ← Head: juanfont/fix-crash-node-id

📝 Commits (1)

  • 459c2af Do not access node ID when node is not found

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 hscontrol/noise.go (+0 -1)

📄 Description

This PR fixes #1883

Basically do not access in node if we failed to find it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1912 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 4/23/2024 **Status:** ✅ Merged **Merged:** 4/24/2024 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `juanfont/fix-crash-node-id` --- ### 📝 Commits (1) - [`459c2af`](https://github.com/juanfont/headscale/commit/459c2afab2503c8801aa4e769f5d21b6d550101e) Do not access node ID when node is not found ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/noise.go` (+0 -1) </details> ### 📄 Description This PR fixes #1883 Basically do not access in node if we failed to find it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:02 +01:00
adam closed this issue 2025-12-29 03:21:03 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2393
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?