[PR #1853] [MERGED] Use newer fork of termcolor #2350

Closed
opened 2025-12-29 03:20:53 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1853
Author: @SergeAx
Created: 3/31/2024
Status: Merged
Merged: 4/16/2024
Merged by: @juanfont

Base: mainHead: main


📝 Commits (1)

📊 Changes

4 files changed (+5 additions, -8 deletions)

View changed files

📝 cmd/headscale/headscale.go (+1 -1)
📝 flake.nix (+1 -1)
📝 go.mod (+1 -1)
📝 go.sum (+2 -5)

📄 Description

jagottsicher's fork fixed a bug in Windows implementation. While Windows may be not intended as a target platform, some contributors (yours truly included) may prefer it for development.

Also ran go mod tidy, thus three more unnecessary lines are removed from go.sum

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Fixes #1842


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1853 **Author:** [@SergeAx](https://github.com/SergeAx) **Created:** 3/31/2024 **Status:** ✅ Merged **Merged:** 4/16/2024 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`5609799`](https://github.com/juanfont/headscale/commit/560979900b6935cc1aef42bab6a6a61ad39fdcec) use newer fork of termcolor (#1842) ### 📊 Changes **4 files changed** (+5 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `cmd/headscale/headscale.go` (+1 -1) 📝 `flake.nix` (+1 -1) 📝 `go.mod` (+1 -1) 📝 `go.sum` (+2 -5) </details> ### 📄 Description jagottsicher's fork fixed a bug in Windows implementation. While Windows may be not intended as a target platform, some contributors (yours truly included) may prefer it for development. Also ran go mod tidy, thus three more unnecessary lines are removed from go.sum - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md Fixes #1842 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:20:53 +01:00
adam closed this issue 2025-12-29 03:20:53 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2350