starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1820] [CLOSED] feat: Support SSH session recording configuration #2335

New Issue
Closed
opened 2025-12-29 03:20:49 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:20:49 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1820
Author: @Qup42
Created: 3/10/2024
Status: ❌ Closed

Base: main ← Head: feat/sshSessionRecording

📝 Commits (3)

  • 04c7c5b feat: add recorder and enforceRecorder support in SSH ACL
  • 31ee9bb test: add tests for recorder and enforceRecorder SSH ACL rules
  • c6593a2 feat: add a message to the user that the session is recorded

📊 Changes

3 files changed (+143 additions, -10 deletions)

View changed files

📝 hscontrol/policy/acls.go (+25 -0)
📝 hscontrol/policy/acls_test.go (+111 -5)
📝 hscontrol/policy/acls_types.go (+7 -5)

📄 Description

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

This PR makes the necessary backend changes to support SSH session recording. This consists of handling the recorder and enforceRecorder fields1 of the ssh ACL rules. Providing a compatible recorder is not part of this PR.

Resolves #1793

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1820 **Author:** [@Qup42](https://github.com/Qup42) **Created:** 3/10/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/sshSessionRecording` --- ### 📝 Commits (3) - [`04c7c5b`](https://github.com/juanfont/headscale/commit/04c7c5b0b63f3599a69e19d63fb94865df5a0e27) feat: add `recorder` and `enforceRecorder` support in SSH ACL - [`31ee9bb`](https://github.com/juanfont/headscale/commit/31ee9bb4a870320032b1c6457e895b0182a15dfb) test: add tests for `recorder` and `enforceRecorder` SSH ACL rules - [`c6593a2`](https://github.com/juanfont/headscale/commit/c6593a2bcbc14198f4b1b89e1f10d4047758dd58) feat: add a message to the user that the session is recorded ### 📊 Changes **3 files changed** (+143 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/policy/acls.go` (+25 -0) 📝 `hscontrol/policy/acls_test.go` (+111 -5) 📝 `hscontrol/policy/acls_types.go` (+7 -5) </details> ### 📄 Description - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [x] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md This PR makes the necessary backend changes to support [SSH session recording](https://tailscale.com/kb/1246/tailscale-ssh-session-recording). This consists of handling the `recorder` and `enforceRecorder` fields[^1] of the `ssh` ACL rules. Providing a compatible recorder is not part of this PR. Resolves #1793 [^1]: https://tailscale.com/kb/1246/tailscale-ssh-session-recording#turn-on-session-recording-in-acls --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:20:49 +01:00
adam closed this issue 2025-12-29 03:20:49 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2335
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?