starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1765] [MERGED] improve errors for missing directories #2305

New Issue
Closed
opened 2025-12-29 03:20:38 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:20:38 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1765
Author: @kradalby
Created: 2/16/2024
Status: ✅ Merged
Merged: 2/17/2024
Merged by: @kradalby

Base: main ← Head: var-run-docker

📝 Commits (3)

  • 4ea8027 improve errors for missing directories
  • df3d406 update container docs
  • 97312eb update changelog with /var changes

📊 Changes

5 files changed (+51 additions, -2 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 docs/running-headscale-container.md (+9 -2)
📝 hscontrol/app.go (+14 -0)
📝 hscontrol/db/db.go (+7 -0)
📝 hscontrol/util/file.go (+20 -0)

📄 Description

The new docker image does not have all headscale directories pre-created, and while 99% of the cases, these dirs should be mounted into the container and therefore created, it might be a source of confusion.

This commit improves the error messages for these cases.

Depends on a changelog update after https://github.com/juanfont/headscale/pull/1763

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1765 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 2/16/2024 **Status:** ✅ Merged **Merged:** 2/17/2024 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `var-run-docker` --- ### 📝 Commits (3) - [`4ea8027`](https://github.com/juanfont/headscale/commit/4ea802781c25e88fb24d60a424f0555aa0a5e24a) improve errors for missing directories - [`df3d406`](https://github.com/juanfont/headscale/commit/df3d4066d03b4618d826659fe1fe8e65ef722df5) update container docs - [`97312eb`](https://github.com/juanfont/headscale/commit/97312eb90af93745dc219973a050d4c58c4d423e) update changelog with /var changes ### 📊 Changes **5 files changed** (+51 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `docs/running-headscale-container.md` (+9 -2) 📝 `hscontrol/app.go` (+14 -0) 📝 `hscontrol/db/db.go` (+7 -0) 📝 `hscontrol/util/file.go` (+20 -0) </details> ### 📄 Description The new docker image does not have all headscale directories pre-created, and while 99% of the cases, these dirs should be mounted into the container and therefore created, it might be a source of confusion. This commit improves the error messages for these cases. Depends on a changelog update after https://github.com/juanfont/headscale/pull/1763 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:20:38 +01:00
adam closed this issue 2025-12-29 03:20:38 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2305
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?