starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1730] [MERGED] Prepare notify channel before sending first update #2278

New Issue
Closed
opened 2025-12-29 03:20:31 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:20:31 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1730
Author: @kradalby
Created: 2/9/2024
Status: ✅ Merged
Merged: 2/12/2024
Merged by: @kradalby

Base: main ← Head: tighten-notify

📝 Commits (2)

  • c90c7c4 create channel before sending first update
  • 264334f do not notify on register, wait for connect

📊 Changes

3 files changed (+30 additions, -45 deletions)

View changed files

📝 hscontrol/auth.go (+8 -19)
📝 hscontrol/grpcv1.go (+0 -10)
📝 hscontrol/poll.go (+22 -16)

📄 Description

This tries to solve a timing issue where nodes might send updates between the first full map and the channel for getting updates being opened which means they might not get endpoints or derp updates from peers.

In addition, it removes the notifier in the registration stages, with the reasoning that its better to announce when the nodes contacts the poller as it is "more ready" and not missing things like hostinfo.

Signed-off-by: Kristoffer Dalby kristoffer@tailscale.com

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1730 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 2/9/2024 **Status:** ✅ Merged **Merged:** 2/12/2024 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `tighten-notify` --- ### 📝 Commits (2) - [`c90c7c4`](https://github.com/juanfont/headscale/commit/c90c7c487a9cc3c759b81751b664ca7335648b34) create channel before sending first update - [`264334f`](https://github.com/juanfont/headscale/commit/264334f4e9f4700d1314bdcd94832a7a6c8c50ae) do not notify on register, wait for connect ### 📊 Changes **3 files changed** (+30 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/auth.go` (+8 -19) 📝 `hscontrol/grpcv1.go` (+0 -10) 📝 `hscontrol/poll.go` (+22 -16) </details> ### 📄 Description This tries to solve a timing issue where nodes might send updates between the first full map and the channel for getting updates being opened which means they might not get endpoints or derp updates from peers. In addition, it removes the notifier in the registration stages, with the reasoning that its better to announce when the nodes contacts the poller as it is "more ready" and not missing things like hostinfo. Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:20:31 +01:00
adam closed this issue 2025-12-29 03:20:31 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2278
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?