starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1719] [MERGED] Login with OIDC after having been logged out #2270

New Issue
Closed
opened 2025-12-29 03:20:30 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:20:30 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1719
Author: @TotoTheDragon
Created: 2/5/2024
Status: ✅ Merged
Merged: 2/5/2024
Merged by: @kradalby

Base: main ← Head: fix/oidc-missing-nodekey

📝 Commits (1)

  • 304b06a Refresh node key when there is a difference

📊 Changes

1 file changed (+13 additions, -0 deletions)

View changed files

📝 hscontrol/auth.go (+13 -0)

📄 Description

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Fixes https://github.com/juanfont/headscale/issues/1675
Fixes https://github.com/juanfont/headscale/issues/1705

These issues started in the v0.23.0 alpha.
When reauthenticating using oidc, no OldNodeKey is set by the client, the NodeKey set by the client is different from the one headscale has set, but the NodeKey does not get updated to the new one.

A better fix might be to update the nodekey in the RegisterOIDC stack, but my attempts there did not work.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1719 **Author:** [@TotoTheDragon](https://github.com/TotoTheDragon) **Created:** 2/5/2024 **Status:** ✅ Merged **Merged:** 2/5/2024 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `fix/oidc-missing-nodekey` --- ### 📝 Commits (1) - [`304b06a`](https://github.com/juanfont/headscale/commit/304b06ade9cfbbe76915429fe130bdacf676bc27) Refresh node key when there is a difference ### 📊 Changes **1 file changed** (+13 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/auth.go` (+13 -0) </details> ### 📄 Description <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [x] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> Fixes https://github.com/juanfont/headscale/issues/1675 Fixes https://github.com/juanfont/headscale/issues/1705 These issues started in the v0.23.0 alpha. When reauthenticating using oidc, no OldNodeKey is set by the client, the NodeKey set by the client is different from the one headscale has set, but the NodeKey does not get updated to the new one. A better fix might be to update the nodekey in the RegisterOIDC stack, but my attempts there did not work. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:20:30 +01:00
adam closed this issue 2025-12-29 03:20:30 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2270
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?