starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1620] [CLOSED] Do not overwrite the derpmap with default region #2217

New Issue
Closed
opened 2025-12-29 03:20:15 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:20:15 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1620
Author: @Orhideous
Created: 11/27/2023
Status: ❌ Closed

Base: main ← Head: main

📄 Description

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

There are cases when some regions are already specified in derp.yaml (including those with ID 900) - in such cases, you should not overwrite them with the generated ones.

This problem was discussed at Discord.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1620 **Author:** [@Orhideous](https://github.com/Orhideous) **Created:** 11/27/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📄 Description - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md There are cases when some regions are already specified in `derp.yaml` (including those with ID 900) - in such cases, you should not overwrite them with the generated ones. This problem [was discussed](https://discordapp.com/channels/896711691637780480/896711692120129540/1117183778704588800) at Discord. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:20:15 +01:00
adam closed this issue 2025-12-29 03:20:16 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2217
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?