starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1612] [MERGED] move to use tailscfg types over strings/custom types #2209

New Issue
Closed
opened 2025-12-29 03:20:14 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:20:14 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1612
Author: @kradalby
Created: 11/19/2023
Status: ✅ Merged
Merged: 11/21/2023
Merged by: @kradalby

Base: main ← Head: node-db-typess

📝 Commits (4)

  • 1d42224 rename database only fields
  • 783b0b2 use correct endpoint type over string list
  • b75b213 remove HostInfo wrapper
  • 5ac87c9 wrap errors in database hooks

📊 Changes

13 files changed (+147 additions, -154 deletions)

View changed files

📝 hscontrol/db/node_test.go (+2 -1)
📝 hscontrol/db/routes.go (+1 -1)
📝 hscontrol/db/routes_test.go (+9 -9)
📝 hscontrol/grpcv1.go (+1 -1)
📝 hscontrol/mapper/mapper.go (+1 -1)
📝 hscontrol/mapper/mapper_test.go (+3 -6)
📝 hscontrol/mapper/tail.go (+4 -11)
📝 hscontrol/mapper/tail_test.go (+5 -4)
📝 hscontrol/policy/acls.go (+12 -6)
📝 hscontrol/policy/acls_test.go (+43 -31)
📝 hscontrol/poll.go (+4 -5)
📝 hscontrol/types/common.go (+0 -27)
📝 hscontrol/types/node.go (+62 -51)

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1612 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 11/19/2023 **Status:** ✅ Merged **Merged:** 11/21/2023 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `node-db-typess` --- ### 📝 Commits (4) - [`1d42224`](https://github.com/juanfont/headscale/commit/1d4222412f12f8a7922967e8058e20301c72dd43) rename database only fields - [`783b0b2`](https://github.com/juanfont/headscale/commit/783b0b27c14588bc25275b0f5c5d1986b52d2a9d) use correct endpoint type over string list - [`b75b213`](https://github.com/juanfont/headscale/commit/b75b21391d2f18731c0cbcba5453d1c0f5d647d7) remove HostInfo wrapper - [`5ac87c9`](https://github.com/juanfont/headscale/commit/5ac87c95f795620b408e031efbb9eece9004b224) wrap errors in database hooks ### 📊 Changes **13 files changed** (+147 additions, -154 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/db/node_test.go` (+2 -1) 📝 `hscontrol/db/routes.go` (+1 -1) 📝 `hscontrol/db/routes_test.go` (+9 -9) 📝 `hscontrol/grpcv1.go` (+1 -1) 📝 `hscontrol/mapper/mapper.go` (+1 -1) 📝 `hscontrol/mapper/mapper_test.go` (+3 -6) 📝 `hscontrol/mapper/tail.go` (+4 -11) 📝 `hscontrol/mapper/tail_test.go` (+5 -4) 📝 `hscontrol/policy/acls.go` (+12 -6) 📝 `hscontrol/policy/acls_test.go` (+43 -31) 📝 `hscontrol/poll.go` (+4 -5) 📝 `hscontrol/types/common.go` (+0 -27) 📝 `hscontrol/types/node.go` (+62 -51) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:20:14 +01:00
adam closed this issue 2025-12-29 03:20:14 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2209
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?