starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1611] [MERGED] Remove support for non-noise clients (pre-1.32) #2208

New Issue
Closed
opened 2025-12-29 03:20:13 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:20:13 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1611
Author: @kradalby
Created: 11/19/2023
Status: ✅ Merged
Merged: 11/23/2023
Merged by: @kradalby

Base: main ← Head: deprecate-old-versions

📝 Commits (10+)

  • 5ef782f disable tests for unsupported versions
  • 04d19f7 remove legacy handlers
  • f91180e remove isNoise occurances
  • c68c559 remove ts2019 build tag
  • 58c5704 remove 2019 private key
  • e1494b2 initial changelog entry
  • 3a678e0 reject unsupported capability versions
  • 225e2c0 define derp key in tests
  • 2900d99 grpc lint fix
  • de3cc20 remove unused marshal function

📊 Changes

72 files changed (+321 additions, -681 deletions)

View changed files

📝 .github/workflows/test-integration-v2-TestACLAllowStarDst.yaml (+0 -1)
📝 .github/workflows/test-integration-v2-TestACLAllowUser80Dst.yaml (+0 -1)
📝 .github/workflows/test-integration-v2-TestACLAllowUserDst.yaml (+0 -1)
📝 .github/workflows/test-integration-v2-TestACLDenyAllPort80.yaml (+0 -1)
📝 .github/workflows/test-integration-v2-TestACLDevice1CanAccessDevice2.yaml (+0 -1)
📝 .github/workflows/test-integration-v2-TestACLHostsInNetMapTable.yaml (+0 -1)
📝 .github/workflows/test-integration-v2-TestACLNamedHostsCanReach.yaml (+0 -1)
📝 .github/workflows/test-integration-v2-TestACLNamedHostsCanReachBySubnet.yaml (+0 -1)
📝 .github/workflows/test-integration-v2-TestApiKeyCommand.yaml (+0 -1)
📝 .github/workflows/test-integration-v2-TestAuthKeyLogoutAndRelogin.yaml (+0 -1)
📝 .github/workflows/test-integration-v2-TestAuthWebFlowAuthenticationPingAll.yaml (+0 -1)
📝 .github/workflows/test-integration-v2-TestAuthWebFlowLogoutAndRelogin.yaml (+0 -1)
📝 .github/workflows/test-integration-v2-TestCreateTailscale.yaml (+0 -1)
📝 .github/workflows/test-integration-v2-TestDERPServerScenario.yaml (+0 -1)
📝 .github/workflows/test-integration-v2-TestEnablingRoutes.yaml (+0 -1)
📝 .github/workflows/test-integration-v2-TestEphemeral.yaml (+0 -1)
📝 .github/workflows/test-integration-v2-TestExpireNode.yaml (+0 -1)
📝 .github/workflows/test-integration-v2-TestHeadscale.yaml (+0 -1)
📝 .github/workflows/test-integration-v2-TestNodeCommand.yaml (+0 -1)
📝 .github/workflows/test-integration-v2-TestNodeExpireCommand.yaml (+0 -1)

...and 52 more files

📄 Description

The goal of this PR is to drop client versions older than 1.32 (over one year old), to allow us to remove a lot of legacy code and only support one protocol.

It will also allow us to use modern MapRequest features and not have us maintain a lot of duplicate code/functionality.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1611 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 11/19/2023 **Status:** ✅ Merged **Merged:** 11/23/2023 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `deprecate-old-versions` --- ### 📝 Commits (10+) - [`5ef782f`](https://github.com/juanfont/headscale/commit/5ef782f2e3ebee20da87ea297eaa022eae54031e) disable tests for unsupported versions - [`04d19f7`](https://github.com/juanfont/headscale/commit/04d19f7609c8def81b1ac00cda65a5576bce6feb) remove legacy handlers - [`f91180e`](https://github.com/juanfont/headscale/commit/f91180ea06a7facb29d9c5bf7fc8e714a7bb6636) remove isNoise occurances - [`c68c559`](https://github.com/juanfont/headscale/commit/c68c559bef2af7083bce751c368709ae8b9f5b76) remove ts2019 build tag - [`58c5704`](https://github.com/juanfont/headscale/commit/58c57048d8c33a1cd4d2da5456807ae260323f35) remove 2019 private key - [`e1494b2`](https://github.com/juanfont/headscale/commit/e1494b2ec907d415032faf3e43d1e883c92be3de) initial changelog entry - [`3a678e0`](https://github.com/juanfont/headscale/commit/3a678e081163938220dc8df085154d1ffb633782) reject unsupported capability versions - [`225e2c0`](https://github.com/juanfont/headscale/commit/225e2c0cd43caaf88a7138ab3ea5e9727707c4a0) define derp key in tests - [`2900d99`](https://github.com/juanfont/headscale/commit/2900d99a2198194a338e9e69d7491fbbeb9ec0ab) grpc lint fix - [`de3cc20`](https://github.com/juanfont/headscale/commit/de3cc205498bd7d7e659b9749069ed564f99a589) remove unused marshal function ### 📊 Changes **72 files changed** (+321 additions, -681 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test-integration-v2-TestACLAllowStarDst.yaml` (+0 -1) 📝 `.github/workflows/test-integration-v2-TestACLAllowUser80Dst.yaml` (+0 -1) 📝 `.github/workflows/test-integration-v2-TestACLAllowUserDst.yaml` (+0 -1) 📝 `.github/workflows/test-integration-v2-TestACLDenyAllPort80.yaml` (+0 -1) 📝 `.github/workflows/test-integration-v2-TestACLDevice1CanAccessDevice2.yaml` (+0 -1) 📝 `.github/workflows/test-integration-v2-TestACLHostsInNetMapTable.yaml` (+0 -1) 📝 `.github/workflows/test-integration-v2-TestACLNamedHostsCanReach.yaml` (+0 -1) 📝 `.github/workflows/test-integration-v2-TestACLNamedHostsCanReachBySubnet.yaml` (+0 -1) 📝 `.github/workflows/test-integration-v2-TestApiKeyCommand.yaml` (+0 -1) 📝 `.github/workflows/test-integration-v2-TestAuthKeyLogoutAndRelogin.yaml` (+0 -1) 📝 `.github/workflows/test-integration-v2-TestAuthWebFlowAuthenticationPingAll.yaml` (+0 -1) 📝 `.github/workflows/test-integration-v2-TestAuthWebFlowLogoutAndRelogin.yaml` (+0 -1) 📝 `.github/workflows/test-integration-v2-TestCreateTailscale.yaml` (+0 -1) 📝 `.github/workflows/test-integration-v2-TestDERPServerScenario.yaml` (+0 -1) 📝 `.github/workflows/test-integration-v2-TestEnablingRoutes.yaml` (+0 -1) 📝 `.github/workflows/test-integration-v2-TestEphemeral.yaml` (+0 -1) 📝 `.github/workflows/test-integration-v2-TestExpireNode.yaml` (+0 -1) 📝 `.github/workflows/test-integration-v2-TestHeadscale.yaml` (+0 -1) 📝 `.github/workflows/test-integration-v2-TestNodeCommand.yaml` (+0 -1) 📝 `.github/workflows/test-integration-v2-TestNodeExpireCommand.yaml` (+0 -1) _...and 52 more files_ </details> ### 📄 Description The goal of this PR is to drop client versions older than 1.32 (over one year old), to allow us to remove a lot of legacy code and only support one protocol. It will also allow us to use modern MapRequest features and not have us maintain a lot of duplicate code/functionality. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:20:13 +01:00
adam closed this issue 2025-12-29 03:20:14 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2208
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?