starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-13 12:50:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1553] [MERGED] Rename Machine to Node #2174

New Issue
Closed
opened 2025-12-29 03:20:05 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:20:05 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1553
Author: @juanfont
Created: 9/22/2023
Status: ✅ Merged
Merged: 9/24/2023
Merged by: @kradalby

Base: main ← Head: machine-to-node-2

📝 Commits (10+)

  • af992e2 Initial file rename
  • c28f7f1 Renamed types files
  • 6d1a71d Updated grpc + generated stuff to Node
  • 7c3991c Added migrations to rename to node
  • 861becb Updated naming in db package
  • 1c40581 Updated mapper
  • 5325e19 Changed to node in mapper
  • 21c3b0a Renamed machine to node in main hscontrol package
  • 8a88fee Updated machine in remaining files
  • 195c7d3 Linting

📊 Changes

57 files changed (+5223 additions, -5239 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 cmd/headscale/cli/debug.go (+5 -5)
📝 cmd/headscale/cli/nodes.go (+66 -66)
📝 cmd/headscale/cli/root.go (+1 -1)
📝 cmd/headscale/cli/routes.go (+5 -5)
📝 gen/go/headscale/v1/apikey.pb.go (+1 -1)
📝 gen/go/headscale/v1/device.pb.go (+1 -1)
📝 gen/go/headscale/v1/headscale.pb.go (+256 -265)
📝 gen/go/headscale/v1/headscale.pb.gw.go (+212 -212)
📝 gen/go/headscale/v1/headscale_grpc.pb.go (+153 -153)
➖ gen/go/headscale/v1/machine.pb.go (+0 -1618)
➕ gen/go/headscale/v1/node.pb.go (+1608 -0)
📝 gen/go/headscale/v1/preauthkey.pb.go (+1 -1)
📝 gen/go/headscale/v1/routes.pb.go (+97 -98)
📝 gen/go/headscale/v1/user.pb.go (+1 -1)
📝 gen/openapiv2/headscale/v1/headscale.swagger.json (+75 -75)
📝 gen/openapiv2/headscale/v1/node.swagger.json (+1 -1)
📝 hscontrol/app.go (+4 -4)
📝 hscontrol/auth.go (+114 -114)
📝 hscontrol/auth_legacy.go (+2 -2)

...and 37 more files

📄 Description

Almost three years ago I made the mistake of calling Machines to the Tailscale clients in Headscale.

Since then it has become very obvious that they should be referred as Nodes.

This massive PR fixes that mistake across the codebase.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1553 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 9/22/2023 **Status:** ✅ Merged **Merged:** 9/24/2023 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `machine-to-node-2` --- ### 📝 Commits (10+) - [`af992e2`](https://github.com/juanfont/headscale/commit/af992e28e600552866c6d4a6ddb3efa42c013149) Initial file rename - [`c28f7f1`](https://github.com/juanfont/headscale/commit/c28f7f1e8e29b09473f13c7b659f7588628a3613) Renamed types files - [`6d1a71d`](https://github.com/juanfont/headscale/commit/6d1a71d796791c45af2480bc9ae6b3e5406d7442) Updated grpc + generated stuff to Node - [`7c3991c`](https://github.com/juanfont/headscale/commit/7c3991c4f95b24900f812d6a5b657fb53fb980f1) Added migrations to rename to node - [`861becb`](https://github.com/juanfont/headscale/commit/861becb936de8380f615b0adae9badfc78411f0e) Updated naming in db package - [`1c40581`](https://github.com/juanfont/headscale/commit/1c4058149b910a2f91155588a703537dace0dc3f) Updated mapper - [`5325e19`](https://github.com/juanfont/headscale/commit/5325e19b37fdb82e9086b07fa74cb460df866d11) Changed to node in mapper - [`21c3b0a`](https://github.com/juanfont/headscale/commit/21c3b0a388d4dd4fe534b4bcda000334a4a4bc4f) Renamed machine to node in main hscontrol package - [`8a88fee`](https://github.com/juanfont/headscale/commit/8a88fee22e872581ed0078fc2790874a5397cb15) Updated machine in remaining files - [`195c7d3`](https://github.com/juanfont/headscale/commit/195c7d36f303b50e668acdb1ac758319f35aa2a0) Linting ### 📊 Changes **57 files changed** (+5223 additions, -5239 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `cmd/headscale/cli/debug.go` (+5 -5) 📝 `cmd/headscale/cli/nodes.go` (+66 -66) 📝 `cmd/headscale/cli/root.go` (+1 -1) 📝 `cmd/headscale/cli/routes.go` (+5 -5) 📝 `gen/go/headscale/v1/apikey.pb.go` (+1 -1) 📝 `gen/go/headscale/v1/device.pb.go` (+1 -1) 📝 `gen/go/headscale/v1/headscale.pb.go` (+256 -265) 📝 `gen/go/headscale/v1/headscale.pb.gw.go` (+212 -212) 📝 `gen/go/headscale/v1/headscale_grpc.pb.go` (+153 -153) ➖ `gen/go/headscale/v1/machine.pb.go` (+0 -1618) ➕ `gen/go/headscale/v1/node.pb.go` (+1608 -0) 📝 `gen/go/headscale/v1/preauthkey.pb.go` (+1 -1) 📝 `gen/go/headscale/v1/routes.pb.go` (+97 -98) 📝 `gen/go/headscale/v1/user.pb.go` (+1 -1) 📝 `gen/openapiv2/headscale/v1/headscale.swagger.json` (+75 -75) 📝 `gen/openapiv2/headscale/v1/node.swagger.json` (+1 -1) 📝 `hscontrol/app.go` (+4 -4) 📝 `hscontrol/auth.go` (+114 -114) 📝 `hscontrol/auth_legacy.go` (+2 -2) _...and 37 more files_ </details> ### 📄 Description Almost three years ago I made the mistake of calling Machines to the Tailscale clients in Headscale. Since then it has become very obvious that they should be referred as Nodes. This massive PR fixes that mistake across the codebase. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:20:05 +01:00
adam closed this issue 2025-12-29 03:20:05 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2174
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?