starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1487] [MERGED] Codereorg: Part 4, policy improvement #2145

New Issue
Closed
opened 2025-12-29 03:19:58 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:19:58 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1487
Author: @kradalby
Created: 6/12/2023
Status: ✅ Merged
Merged: 6/21/2023
Merged by: @kradalby

Base: main ← Head: corereorg-p4

📝 Commits (10+)

  • 0c60867 upgrade tailscale
  • 7e54f3c make GenerateFilterRules take machine and peers
  • bce4ab2 Finish SSH
  • de64af1 make generateFilterRules take machine and peers
  • 68f040a remove "stripEmailDomain" argument
  • 1c9c472 make parse destination string into a func
  • bbaed46 only send relevant filterrules to nodes
  • 2fdd48f remove redundant tests
  • b31037b reduce filter rules at the end, so we filter nodes correctly
  • 00ff50d migrate last acl tests away from database

📊 Changes

24 files changed (+1729 additions, -1525 deletions)

View changed files

📝 CHANGELOG.md (+2 -1)
📝 flake.nix (+1 -1)
📝 go.mod (+22 -22)
📝 go.sum (+49 -50)
📝 hscontrol/app.go (+0 -1)
➖ hscontrol/db/acls_test.go (+0 -480)
📝 hscontrol/db/db.go (+6 -9)
📝 hscontrol/db/machine.go (+1 -2)
📝 hscontrol/db/machine_test.go (+17 -154)
📝 hscontrol/db/routes.go (+1 -1)
📝 hscontrol/db/suite_test.go (+0 -1)
📝 hscontrol/grpcv1.go (+1 -2)
📝 hscontrol/mapper/mapper.go (+6 -12)
📝 hscontrol/mapper/mapper_test.go (+7 -13)
📝 hscontrol/mapper/tail.go (+1 -4)
📝 hscontrol/mapper/tail_test.go (+17 -21)
📝 hscontrol/policy/acls.go (+165 -154)
📝 hscontrol/policy/acls_test.go (+1353 -550)
📝 hscontrol/policy/matcher/matcher.go (+12 -3)
📝 hscontrol/poll.go (+0 -3)

...and 4 more files

📄 Description

Signed-off-by: Kristoffer Dalby kristoffer@tailscale.com

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1487 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 6/12/2023 **Status:** ✅ Merged **Merged:** 6/21/2023 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `corereorg-p4` --- ### 📝 Commits (10+) - [`0c60867`](https://github.com/juanfont/headscale/commit/0c60867a3126c5b2e02dbd8a0fc51a70ce92f8e2) upgrade tailscale - [`7e54f3c`](https://github.com/juanfont/headscale/commit/7e54f3c55fda10daa155d29a0c2aa1c71ad7be4f) make GenerateFilterRules take machine and peers - [`bce4ab2`](https://github.com/juanfont/headscale/commit/bce4ab2e599fbbbb7072cb9c8400b09e789934a5) Finish SSH - [`de64af1`](https://github.com/juanfont/headscale/commit/de64af125d9e6f78642482caca7bfe3930686f6f) make generateFilterRules take machine and peers - [`68f040a`](https://github.com/juanfont/headscale/commit/68f040a89c2036d4fa3a22db2870581c0ee0d045) remove "stripEmailDomain" argument - [`1c9c472`](https://github.com/juanfont/headscale/commit/1c9c472d2cd71f54553666a85250e60064ab7b6d) make parse destination string into a func - [`bbaed46`](https://github.com/juanfont/headscale/commit/bbaed461e139762e635d8b8d37c974d99957c56f) only send relevant filterrules to nodes - [`2fdd48f`](https://github.com/juanfont/headscale/commit/2fdd48ffdc0eed5a95e85f807e5b2de1a1ae8b0b) remove redundant tests - [`b31037b`](https://github.com/juanfont/headscale/commit/b31037b5af276b4b615f6f1a44cbe1be79941314) reduce filter rules at the end, so we filter nodes correctly - [`00ff50d`](https://github.com/juanfont/headscale/commit/00ff50d68ca149e3d79c8e054f5c5111163c0755) migrate last acl tests away from database ### 📊 Changes **24 files changed** (+1729 additions, -1525 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+2 -1) 📝 `flake.nix` (+1 -1) 📝 `go.mod` (+22 -22) 📝 `go.sum` (+49 -50) 📝 `hscontrol/app.go` (+0 -1) ➖ `hscontrol/db/acls_test.go` (+0 -480) 📝 `hscontrol/db/db.go` (+6 -9) 📝 `hscontrol/db/machine.go` (+1 -2) 📝 `hscontrol/db/machine_test.go` (+17 -154) 📝 `hscontrol/db/routes.go` (+1 -1) 📝 `hscontrol/db/suite_test.go` (+0 -1) 📝 `hscontrol/grpcv1.go` (+1 -2) 📝 `hscontrol/mapper/mapper.go` (+6 -12) 📝 `hscontrol/mapper/mapper_test.go` (+7 -13) 📝 `hscontrol/mapper/tail.go` (+1 -4) 📝 `hscontrol/mapper/tail_test.go` (+17 -21) 📝 `hscontrol/policy/acls.go` (+165 -154) 📝 `hscontrol/policy/acls_test.go` (+1353 -550) 📝 `hscontrol/policy/matcher/matcher.go` (+12 -3) 📝 `hscontrol/poll.go` (+0 -3) _...and 4 more files_ </details> ### 📄 Description Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:19:58 +01:00
adam closed this issue 2025-12-29 03:19:58 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2145
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?