[PR #1463] [MERGED] Add ca-certificates #2133

Closed
opened 2025-12-29 03:19:54 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1463
Author: @6ixfalls
Created: 5/12/2023
Status: Merged
Merged: 5/12/2023
Merged by: @juanfont

Base: mainHead: patch/docker-certs


📝 Commits (1)

  • dabced4 Add ca-certificates to Dockerfile

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 Dockerfile (+3 -0)

📄 Description

Add ca-certificates package to fix headscale not being able to resolve OIDC providers correctly due to LetsEncrypt not being in the default certificate registry.

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

If possible, would be nice to also push this to v0.22.2 so a new version isn't required to be able to use headscale correctly without building your own image.
Fixes #1462


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1463 **Author:** [@6ixfalls](https://github.com/6ixfalls) **Created:** 5/12/2023 **Status:** ✅ Merged **Merged:** 5/12/2023 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `patch/docker-certs` --- ### 📝 Commits (1) - [`dabced4`](https://github.com/juanfont/headscale/commit/dabced4de8c1d019914f6413d57234feeefb76b2) Add ca-certificates to Dockerfile ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+3 -0) </details> ### 📄 Description <!-- Headscale is "Open Source, acknowledged contribution", this means that any contribution will have to be discussed with the Maintainers before being submitted. This model has been chosen to reduce the risk of burnout by limiting the maintenance overhead of reviewing and validating third-party code. Headscale is open to code contributions for bug fixes without discussion. If you find mistakes in the documentation, please submit a fix to the documentation. --> Add ca-certificates package to fix headscale not being able to resolve OIDC providers correctly due to LetsEncrypt not being in the default certificate registry. <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> If possible, would be nice to also push this to v0.22.2 so a new version isn't required to be able to use headscale correctly without building your own image. Fixes #1462 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:19:54 +01:00
adam closed this issue 2025-12-29 03:19:54 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2133