starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-13 12:50:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1428] [MERGED] Disable and Delete route must affect both exit routes (IPv4 and IPv6) #2108

New Issue
Closed
opened 2025-12-29 03:19:47 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:19:47 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1428
Author: @juanfont
Created: 5/7/2023
Status: ✅ Merged
Merged: 5/7/2023
Merged by: @juanfont

Base: main ← Head: disable-both-exit-routes

📝 Commits (2)

  • a63742e Disable and Delete route must affect both exit routes (IPv4 and IPv6)
  • 544311a Update changelog

📊 Changes

3 files changed (+82 additions, -4 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 routes.go (+50 -4)
📝 routes_test.go (+31 -0)

📄 Description

We should disable (or delete) both exit routes of a node at the same time - the same way we already enable both.

As per https://github.com/juanfont/headscale/issues/804#issuecomment-1399314002

Fixes #1284

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1428 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 5/7/2023 **Status:** ✅ Merged **Merged:** 5/7/2023 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `disable-both-exit-routes` --- ### 📝 Commits (2) - [`a63742e`](https://github.com/juanfont/headscale/commit/a63742e9345f876e0612f087b22de38f0d7d8e28) Disable and Delete route must affect both exit routes (IPv4 and IPv6) - [`544311a`](https://github.com/juanfont/headscale/commit/544311ab673678d8b7728cbb4a1550e35091dca2) Update changelog ### 📊 Changes **3 files changed** (+82 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `routes.go` (+50 -4) 📝 `routes_test.go` (+31 -0) </details> ### 📄 Description We should disable (or delete) both exit routes of a node at the same time - the same way we already enable both. As per https://github.com/juanfont/headscale/issues/804#issuecomment-1399314002 Fixes #1284 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:19:47 +01:00
adam closed this issue 2025-12-29 03:19:47 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2108
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?