starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-13 12:50:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1404] [CLOSED] [In Queue] Rename Machine to Node #2093

New Issue
Closed
opened 2025-12-29 03:19:44 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:19:44 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1404
Author: @juanfont
Created: 5/1/2023
Status: ❌ Closed

Base: main ← Head: rename-machine-node

📝 Commits (8)

  • 47bc930 Rename files
  • ae03f44 Rename machine in protos and gen code
  • cf22604 Changed DB objects and added migrations
  • 46221cc Updated CLI entries
  • 89fffea Deleted old pb machine stuff
  • 83b4389 Refactored app code with Node
  • 851da9d Refactored integration tests
  • 9f7c25e Refactor unit tests

📊 Changes

53 files changed (+4136 additions, -4124 deletions)

View changed files

📝 acls.go (+45 -45)
📝 acls_test.go (+145 -145)
📝 acls_types.go (+1 -1)
📝 api.go (+3 -3)
📝 api_common.go (+8 -8)
📝 app.go (+27 -27)
📝 cmd/headscale/cli/debug.go (+8 -8)
📝 cmd/headscale/cli/nodes.go (+59 -59)
📝 cmd/headscale/cli/routes.go (+11 -11)
📝 db.go (+50 -46)
📝 dns.go (+11 -11)
📝 dns_test.go (+30 -30)
📝 gen/go/headscale/v1/apikey.pb.go (+1 -1)
📝 gen/go/headscale/v1/device.pb.go (+1 -1)
📝 gen/go/headscale/v1/headscale.pb.go (+256 -265)
📝 gen/go/headscale/v1/headscale.pb.gw.go (+212 -212)
📝 gen/go/headscale/v1/headscale_grpc.pb.go (+189 -161)
➖ gen/go/headscale/v1/machine.pb.go (+0 -1618)
➕ gen/go/headscale/v1/node.pb.go (+1608 -0)
📝 gen/go/headscale/v1/preauthkey.pb.go (+1 -1)

...and 33 more files

📄 Description

Almost three years ago I made the mistake of calling Machines to the Tailscale clients in Headscale.

Since then it has become very obvious that they should be referred as Nodes.

This massive PR fixes that mistake across the codebase.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1404 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 5/1/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `rename-machine-node` --- ### 📝 Commits (8) - [`47bc930`](https://github.com/juanfont/headscale/commit/47bc930aced284bc8596380a0b27a2e552abfc3f) Rename files - [`ae03f44`](https://github.com/juanfont/headscale/commit/ae03f440ee46f6489d38ec0f08c33c3cf83eb067) Rename machine in protos and gen code - [`cf22604`](https://github.com/juanfont/headscale/commit/cf22604a4bff41ab9c92d878fb0a244e2059d868) Changed DB objects and added migrations - [`46221cc`](https://github.com/juanfont/headscale/commit/46221cc22010c3968ab6465076ee03fdcd5bb94e) Updated CLI entries - [`89fffea`](https://github.com/juanfont/headscale/commit/89fffeab31ab71e5f34533653f3cb93422b079a4) Deleted old pb machine stuff - [`83b4389`](https://github.com/juanfont/headscale/commit/83b4389090acaafb0f135a38ea56c9068bdfef79) Refactored app code with Node - [`851da9d`](https://github.com/juanfont/headscale/commit/851da9d674df2b6fa5ca8338d04750a6058055d4) Refactored integration tests - [`9f7c25e`](https://github.com/juanfont/headscale/commit/9f7c25e8536ca0f666566df9ee4f7a7e02a99789) Refactor unit tests ### 📊 Changes **53 files changed** (+4136 additions, -4124 deletions) <details> <summary>View changed files</summary> 📝 `acls.go` (+45 -45) 📝 `acls_test.go` (+145 -145) 📝 `acls_types.go` (+1 -1) 📝 `api.go` (+3 -3) 📝 `api_common.go` (+8 -8) 📝 `app.go` (+27 -27) 📝 `cmd/headscale/cli/debug.go` (+8 -8) 📝 `cmd/headscale/cli/nodes.go` (+59 -59) 📝 `cmd/headscale/cli/routes.go` (+11 -11) 📝 `db.go` (+50 -46) 📝 `dns.go` (+11 -11) 📝 `dns_test.go` (+30 -30) 📝 `gen/go/headscale/v1/apikey.pb.go` (+1 -1) 📝 `gen/go/headscale/v1/device.pb.go` (+1 -1) 📝 `gen/go/headscale/v1/headscale.pb.go` (+256 -265) 📝 `gen/go/headscale/v1/headscale.pb.gw.go` (+212 -212) 📝 `gen/go/headscale/v1/headscale_grpc.pb.go` (+189 -161) ➖ `gen/go/headscale/v1/machine.pb.go` (+0 -1618) ➕ `gen/go/headscale/v1/node.pb.go` (+1608 -0) 📝 `gen/go/headscale/v1/preauthkey.pb.go` (+1 -1) _...and 33 more files_ </details> ### 📄 Description Almost three years ago I made the mistake of calling `Machines` to the Tailscale clients in Headscale. Since then it has become very obvious that they should be referred as `Nodes`. This massive PR fixes that mistake across the codebase. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:19:44 +01:00
adam closed this issue 2025-12-29 03:19:44 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2093
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?