starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1405] [CLOSED] feat: remove user if machine is tagged #2090

New Issue
Closed
opened 2025-12-29 03:19:44 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:19:44 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1405
Author: @ChibangLW
Created: 5/1/2023
Status: ❌ Closed

Base: main ← Head: no-user-for-tagged

📝 Commits (2)

  • 5b071eb feat: remove user if machine is tagged
  • da5f7cf refactor: made config option all lower case

📊 Changes

6 files changed (+45 additions, -19 deletions)

View changed files

📝 api_common.go (+2 -2)
📝 cmd/headscale/headscale_test.go (+2 -1)
📝 config-example.yaml (+5 -0)
📝 config.go (+14 -5)
📝 machine.go (+21 -10)
📝 routes_test.go (+1 -1)

📄 Description

This MR adds the user setting to ditch the user in MagicDNS FQDNs if at least one tag is defined for the project.
A new config option is added. If the option is omited, the MagicDNS FQDN will look the same as it used to (with user).

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1405 **Author:** [@ChibangLW](https://github.com/ChibangLW) **Created:** 5/1/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `no-user-for-tagged` --- ### 📝 Commits (2) - [`5b071eb`](https://github.com/juanfont/headscale/commit/5b071eb856abc03c6522324fde19ce2487d89028) feat: remove user if machine is tagged - [`da5f7cf`](https://github.com/juanfont/headscale/commit/da5f7cf5df0f576e1b17f53cfae4ab3ed44a1150) refactor: made config option all lower case ### 📊 Changes **6 files changed** (+45 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `api_common.go` (+2 -2) 📝 `cmd/headscale/headscale_test.go` (+2 -1) 📝 `config-example.yaml` (+5 -0) 📝 `config.go` (+14 -5) 📝 `machine.go` (+21 -10) 📝 `routes_test.go` (+1 -1) </details> ### 📄 Description This MR adds the user setting to ditch the user in MagicDNS FQDNs if at least one tag is defined for the project. A new config option is added. If the option is omited, the MagicDNS FQDN will look the same as it used to (with user). - [X] read the [CONTRIBUTING guidelines](README.md#contributing) - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:19:44 +01:00
adam closed this issue 2025-12-29 03:19:44 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2090
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?