starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1339] [MERGED] Fix IPv6 in ACLs #2048

New Issue
Closed
opened 2025-12-29 03:19:33 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:19:33 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1339
Author: @kradalby
Created: 4/14/2023
Status: ✅ Merged
Merged: 4/16/2023
Merged by: @kradalby

Base: main ← Head: acl-tests-ipv6

📝 Commits (2)

  • 32ce816 Add failing ipv6 tests
  • 5744487 fix ACL issue allowing ipv4 and ipv6

📊 Changes

9 files changed (+788 additions, -180 deletions)

View changed files

➕ .github/workflows/test-integration-v2-TestACLDevice1CanAccessDevice2.yaml (+57 -0)
➕ .github/workflows/test-integration-v2-TestACLNamedHostsCanReach.yaml (+57 -0)
➕ .github/workflows/test-integration-v2-TestACLNamedHostsCanReachBySubnet.yaml (+57 -0)
📝 Makefile (+4 -17)
📝 acls.go (+61 -11)
📝 acls_test.go (+67 -11)
📝 integration/acl_test.go (+439 -141)
📝 integration/utils.go (+32 -0)
📝 machine.go (+14 -0)

📄 Description

Signed-off-by: Kristoffer Dalby kristoffer@tailscale.com

This PR fixes a series of issues with ACLs and IPv6, were it could not be added at all, and then the underlying connection issues that was then exposed.

Updates #809

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1339 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 4/14/2023 **Status:** ✅ Merged **Merged:** 4/16/2023 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `acl-tests-ipv6` --- ### 📝 Commits (2) - [`32ce816`](https://github.com/juanfont/headscale/commit/32ce816aa0b9945fa9709ef48251d2f396ee56e9) Add failing ipv6 tests - [`5744487`](https://github.com/juanfont/headscale/commit/574448705294b743d81585b9d1d756569fce3fdd) fix ACL issue allowing ipv4 and ipv6 ### 📊 Changes **9 files changed** (+788 additions, -180 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/test-integration-v2-TestACLDevice1CanAccessDevice2.yaml` (+57 -0) ➕ `.github/workflows/test-integration-v2-TestACLNamedHostsCanReach.yaml` (+57 -0) ➕ `.github/workflows/test-integration-v2-TestACLNamedHostsCanReachBySubnet.yaml` (+57 -0) 📝 `Makefile` (+4 -17) 📝 `acls.go` (+61 -11) 📝 `acls_test.go` (+67 -11) 📝 `integration/acl_test.go` (+439 -141) 📝 `integration/utils.go` (+32 -0) 📝 `machine.go` (+14 -0) </details> ### 📄 Description Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com><!-- Please tick if the following things apply. You… --> This PR fixes a series of issues with ACLs and IPv6, were it could not be added at all, and then the underlying connection issues that was then exposed. Updates #809 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:19:33 +01:00
adam closed this issue 2025-12-29 03:19:33 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2048
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?