starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1335] [MERGED] Make sure all clients of a user are ready #2045

New Issue
Closed
opened 2025-12-29 03:19:32 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:19:32 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1335
Author: @juanfont
Created: 4/11/2023
Status: ✅ Merged
Merged: 4/12/2023
Merged by: @kradalby

Base: main ← Head: be-more-strict

📝 Commits (2)

  • fc61da6 Make sure all clients of a user are ready
  • 987a9df Fix issue in WaitForReady for TS<1.22

📊 Changes

4 files changed (+36 additions, -0 deletions)

View changed files

📝 integration/auth_oidc_test.go (+9 -0)
📝 integration/auth_web_flow_test.go (+9 -0)
📝 integration/scenario.go (+9 -0)
📝 integration/tsic/tsic.go (+9 -0)

📄 Description

This PR adds an extra check before leaving the Up() helpers, to better detect when a TS version is broken.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1335 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 4/11/2023 **Status:** ✅ Merged **Merged:** 4/12/2023 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `be-more-strict` --- ### 📝 Commits (2) - [`fc61da6`](https://github.com/juanfont/headscale/commit/fc61da64e1f575a56512d3806fc7391f95bea58f) Make sure all clients of a user are ready - [`987a9df`](https://github.com/juanfont/headscale/commit/987a9df18fb4011b5b3fad284124048e620e674f) Fix issue in WaitForReady for TS<1.22 ### 📊 Changes **4 files changed** (+36 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `integration/auth_oidc_test.go` (+9 -0) 📝 `integration/auth_web_flow_test.go` (+9 -0) 📝 `integration/scenario.go` (+9 -0) 📝 `integration/tsic/tsic.go` (+9 -0) </details> ### 📄 Description This PR adds an extra check before leaving the Up() helpers, to better detect when a TS version is broken. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:19:32 +01:00
adam closed this issue 2025-12-29 03:19:32 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2045
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?