starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1317] [MERGED] Fix CIDR calculation in expandACLPeerAddr #2032

New Issue
Closed
opened 2025-12-29 03:19:22 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:19:22 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1317
Author: @juanfont
Created: 4/5/2023
Status: ✅ Merged
Merged: 4/5/2023
Merged by: @juanfont

Base: main ← Head: fix-ipv6-acls

📝 Commits (1)

  • 7791366 Fix CIDR calculation in expandACLPeerAddr

📊 Changes

2 files changed (+73 additions, -2 deletions)

View changed files

📝 acls.go (+2 -2)
📝 acls_test.go (+71 -0)

📄 Description

The existing code in expandACLPeerAddr would generate an incorrect range when using CIDR notation, both for IPv4 and IPv6 - missing the last IPs.

This PR fixes it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1317 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 4/5/2023 **Status:** ✅ Merged **Merged:** 4/5/2023 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `fix-ipv6-acls` --- ### 📝 Commits (1) - [`7791366`](https://github.com/juanfont/headscale/commit/779136651d6177e27e66e0e4db34d717a7b8f27e) Fix CIDR calculation in expandACLPeerAddr ### 📊 Changes **2 files changed** (+73 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `acls.go` (+2 -2) 📝 `acls_test.go` (+71 -0) </details> ### 📄 Description The existing code in expandACLPeerAddr would generate an incorrect range when using CIDR notation, both for IPv4 and IPv6 - missing the last IPs. This PR fixes it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:19:22 +01:00
adam closed this issue 2025-12-29 03:19:23 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2032
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?