starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1304] [MERGED] Add tests to verify "Hosts" aliases in ACL #2026

New Issue
Closed
opened 2025-12-29 03:19:21 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:19:21 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1304
Author: @kradalby
Created: 3/31/2023
Status: ✅ Merged
Merged: 4/3/2023
Merged by: @kradalby

Base: main ← Head: named-hosts

📝 Commits (3)

  • a095695 Add tests to verify "Hosts" aliases in ACL
  • 4d152ad improve some log messages for peer filtering
  • cfe6c9d add function to expand "ip" so the filter works

📊 Changes

4 files changed (+337 additions, -16 deletions)

View changed files

📝 acls.go (+51 -9)
📝 acls_test.go (+64 -0)
📝 integration/acl_test.go (+212 -0)
📝 machine.go (+10 -7)

📄 Description

This should fix #941.

Signed-off-by: Kristoffer Dalby kristoffer@tailscale.com

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1304 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 3/31/2023 **Status:** ✅ Merged **Merged:** 4/3/2023 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `named-hosts` --- ### 📝 Commits (3) - [`a095695`](https://github.com/juanfont/headscale/commit/a0956952e8ebfc97d8a4e9ab7a8aab69fa32c7bb) Add tests to verify "Hosts" aliases in ACL - [`4d152ad`](https://github.com/juanfont/headscale/commit/4d152add5bc7003ce985a3f094258c801ba9e4fc) improve some log messages for peer filtering - [`cfe6c9d`](https://github.com/juanfont/headscale/commit/cfe6c9d477029d8c5fbe7d8e821823de4c12576e) add function to expand "ip" so the filter works ### 📊 Changes **4 files changed** (+337 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `acls.go` (+51 -9) 📝 `acls_test.go` (+64 -0) 📝 `integration/acl_test.go` (+212 -0) 📝 `machine.go` (+10 -7) </details> ### 📄 Description This should fix #941. Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:19:21 +01:00
adam closed this issue 2025-12-29 03:19:21 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2026
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?