starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1279] [MERGED] Fix issue where ACL * would filter out returning connections #2012

New Issue
Closed
opened 2025-12-29 03:19:17 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:19:17 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1279
Author: @kradalby
Created: 3/23/2023
Status: ✅ Merged
Merged: 3/27/2023
Merged by: @kradalby

Base: main ← Head: star-fix-699

📝 Commits (3)

  • c25a76f Fix issue where * would filter out returning connections
  • cb7da0b Add integration tests for ACLs related to 699
  • b0d3fe4 Update changelog

📊 Changes

8 files changed (+437 additions, -5 deletions)

View changed files

➕ .github/workflows/test-integration-v2-TestACLAllowStarDst.yaml (+57 -0)
➕ .github/workflows/test-integration-v2-TestACLAllowUserDst.yaml (+57 -0)
➕ .github/workflows/test-integration-v2-TestACLDenyAllPort80.yaml (+57 -0)
📝 CHANGELOG.md (+2 -0)
📝 acls.go (+2 -0)
📝 integration/acl_test.go (+162 -1)
📝 machine.go (+6 -0)
📝 machine_test.go (+94 -4)

📄 Description

This should fix #699.

We seemed to have a an implementation where star connections where
filtered out of the netmap preventing a connection to be established.

This should fix this issue.

Signed-off-by: Kristoffer Dalby kristoffer@tailscale.com

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1279 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 3/23/2023 **Status:** ✅ Merged **Merged:** 3/27/2023 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `star-fix-699` --- ### 📝 Commits (3) - [`c25a76f`](https://github.com/juanfont/headscale/commit/c25a76f2d386418783efdc206a4ab7b18346fde9) Fix issue where * would filter out returning connections - [`cb7da0b`](https://github.com/juanfont/headscale/commit/cb7da0b9afec2569ed8e048f23c01a298802c5bb) Add integration tests for ACLs related to 699 - [`b0d3fe4`](https://github.com/juanfont/headscale/commit/b0d3fe4e60c24a093aa55b1f4a7059ca3b8e2b64) Update changelog ### 📊 Changes **8 files changed** (+437 additions, -5 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/test-integration-v2-TestACLAllowStarDst.yaml` (+57 -0) ➕ `.github/workflows/test-integration-v2-TestACLAllowUserDst.yaml` (+57 -0) ➕ `.github/workflows/test-integration-v2-TestACLDenyAllPort80.yaml` (+57 -0) 📝 `CHANGELOG.md` (+2 -0) 📝 `acls.go` (+2 -0) 📝 `integration/acl_test.go` (+162 -1) 📝 `machine.go` (+6 -0) 📝 `machine_test.go` (+94 -4) </details> ### 📄 Description This should fix #699. We seemed to have a an implementation where star connections where filtered out of the netmap preventing a connection to be established. This should fix this issue. Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com><!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [x] added unit tests - [x] added integration tests - [ ] updated documentation if needed - [x] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:19:17 +01:00
adam closed this issue 2025-12-29 03:19:17 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2012
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?