starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1256] [MERGED] adding some sleep on re-registration after machine expired #1998

New Issue
Closed
opened 2025-12-29 03:19:13 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:19:13 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1256
Author: @win-t
Created: 3/7/2023
Status: ✅ Merged
Merged: 3/20/2023
Merged by: @kradalby

Base: main ← Head: add-delay-on-registration

📝 Commits (1)

  • 2640c1f adding some sleep on re-registration after machine expired

📊 Changes

1 file changed (+9 additions, -2 deletions)

View changed files

📝 protocol_common.go (+9 -2)

📄 Description

This PR does 2 things:

  • replace time.NewTicker with time.After, because if you use time.Ticker and never stop it, it will leak some resource
  • adding the same hacky logic on re-registration of expired machine, without it, the headsacle will got hammered by tailscale client

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1256 **Author:** [@win-t](https://github.com/win-t) **Created:** 3/7/2023 **Status:** ✅ Merged **Merged:** 3/20/2023 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `add-delay-on-registration` --- ### 📝 Commits (1) - [`2640c1f`](https://github.com/juanfont/headscale/commit/2640c1fbe52fbd2579a8ef4dc59bef4f567188bb) adding some sleep on re-registration after machine expired ### 📊 Changes **1 file changed** (+9 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `protocol_common.go` (+9 -2) </details> ### 📄 Description This PR does 2 things: - replace time.NewTicker with time.After, because if you use time.Ticker and never stop it, it will leak some resource - adding the same hacky logic on re-registration of expired machine, without it, the headsacle will got hammered by tailscale client --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:19:13 +01:00
adam closed this issue 2025-12-29 03:19:13 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1998
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?