starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1244] [MERGED] Allow to delete routes #1986

New Issue
Closed
opened 2025-12-29 03:19:09 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:19:09 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1244
Author: @juanfont
Created: 3/3/2023
Status: ✅ Merged
Merged: 3/6/2023
Merged by: @kradalby

Base: main ← Head: delete-routes

📝 Commits (5)

  • 76aeb64 Update proto to include DeleteRoute endpoint
  • b46a076 Update autogenerated code
  • 98ad532 Implemented route delete + glue code + tests
  • 33e9f80 Delete routes when a machine is deleted
  • fdf0cff Expose DeleteRoute in the CLI

📊 Changes

17 files changed (+790 additions, -258 deletions)

View changed files

📝 cmd/headscale/cli/routes.go (+51 -1)
📝 gen/go/headscale/v1/apikey.pb.go (+13 -16)
📝 gen/go/headscale/v1/device.pb.go (+18 -21)
📝 gen/go/headscale/v1/headscale.pb.go (+95 -85)
📝 gen/go/headscale/v1/headscale.pb.gw.go (+218 -12)
📝 gen/go/headscale/v1/headscale_grpc.pb.go (+38 -25)
📝 gen/go/headscale/v1/machine.pb.go (+29 -32)
📝 gen/go/headscale/v1/preauthkey.pb.go (+13 -16)
📝 gen/go/headscale/v1/routes.pb.go (+141 -29)
📝 gen/go/headscale/v1/user.pb.go (+17 -20)
📝 gen/openapiv2/headscale/v1/headscale.swagger.json (+34 -0)
📝 grpcv1.go (+12 -0)
📝 machine.go (+10 -0)
📝 proto/headscale/v1/headscale.proto (+6 -0)
📝 proto/headscale/v1/routes.proto (+8 -1)
📝 routes.go (+28 -0)
📝 routes_test.go (+59 -0)

📄 Description

This PR adds support to delete routes from the CLI and the API.

It also deletes the routes of a machine when it is deleted (https://github.com/juanfont/headscale/issues/1228)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1244 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 3/3/2023 **Status:** ✅ Merged **Merged:** 3/6/2023 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `delete-routes` --- ### 📝 Commits (5) - [`76aeb64`](https://github.com/juanfont/headscale/commit/76aeb648b602787e514d554c38cc515e8d16cceb) Update proto to include DeleteRoute endpoint - [`b46a076`](https://github.com/juanfont/headscale/commit/b46a07675a8f05adfeea457ea1f48ab2f3ab746a) Update autogenerated code - [`98ad532`](https://github.com/juanfont/headscale/commit/98ad5328a06ccf01cf0f6798328b69884cc03838) Implemented route delete + glue code + tests - [`33e9f80`](https://github.com/juanfont/headscale/commit/33e9f80b9dbc8801a5dd561fab2e725ca7ff20e1) Delete routes when a machine is deleted - [`fdf0cff`](https://github.com/juanfont/headscale/commit/fdf0cffb6c8b00ad1ed1af415faa3cf53cd56253) Expose DeleteRoute in the CLI ### 📊 Changes **17 files changed** (+790 additions, -258 deletions) <details> <summary>View changed files</summary> 📝 `cmd/headscale/cli/routes.go` (+51 -1) 📝 `gen/go/headscale/v1/apikey.pb.go` (+13 -16) 📝 `gen/go/headscale/v1/device.pb.go` (+18 -21) 📝 `gen/go/headscale/v1/headscale.pb.go` (+95 -85) 📝 `gen/go/headscale/v1/headscale.pb.gw.go` (+218 -12) 📝 `gen/go/headscale/v1/headscale_grpc.pb.go` (+38 -25) 📝 `gen/go/headscale/v1/machine.pb.go` (+29 -32) 📝 `gen/go/headscale/v1/preauthkey.pb.go` (+13 -16) 📝 `gen/go/headscale/v1/routes.pb.go` (+141 -29) 📝 `gen/go/headscale/v1/user.pb.go` (+17 -20) 📝 `gen/openapiv2/headscale/v1/headscale.swagger.json` (+34 -0) 📝 `grpcv1.go` (+12 -0) 📝 `machine.go` (+10 -0) 📝 `proto/headscale/v1/headscale.proto` (+6 -0) 📝 `proto/headscale/v1/routes.proto` (+8 -1) 📝 `routes.go` (+28 -0) 📝 `routes_test.go` (+59 -0) </details> ### 📄 Description This PR adds support to delete routes from the CLI and the API. It also deletes the routes of a machine when it is deleted (https://github.com/juanfont/headscale/issues/1228) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:19:09 +01:00
adam closed this issue 2025-12-29 03:19:09 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1986
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?