starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1201] [MERGED] Return 404 on unmatched routes #1961

New Issue
Closed
opened 2025-12-29 03:19:03 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:19:03 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1201
Author: @dnaq
Created: 2/3/2023
Status: ✅ Merged
Merged: 3/3/2023
Merged by: @kradalby

Base: main ← Head: main

📝 Commits (1)

  • 803d624 Return 404 on unmatched routes

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 app.go (+3 -2)

📄 Description

This commit makes headscale return
HTTP status code 404 (not found) for any
requests it doesn't know how to handle.

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1201 **Author:** [@dnaq](https://github.com/dnaq) **Created:** 2/3/2023 **Status:** ✅ Merged **Merged:** 3/3/2023 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`803d624`](https://github.com/juanfont/headscale/commit/803d62458953d6987cbf60146d5797b1624831b7) Return 404 on unmatched routes ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app.go` (+3 -2) </details> ### 📄 Description This commit makes headscale return HTTP status code 404 (not found) for any requests it doesn't know how to handle. <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:19:03 +01:00
adam closed this issue 2025-12-29 03:19:03 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1961
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?