starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1191] [MERGED] Set OpenID Connect Expiry #1950

New Issue
Closed
opened 2025-12-29 03:19:00 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:19:00 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1191
Author: @kradalby
Created: 1/31/2023
Status: ✅ Merged
Merged: 1/31/2023
Merged by: @kradalby

Base: main ← Head: node-expiry

📝 Commits (1)

  • 07940ec Set OpenID Connect Expiry

📊 Changes

10 files changed (+88 additions, -22 deletions)

View changed files

📝 .github/workflows/test-integration-v2-TestOIDCExpireNodesBasedOnTokenExpiry.yaml (+2 -2)
📝 CHANGELOG.md (+3 -0)
📝 cmd/gh-action-integration-generator/main.go (+1 -1)
📝 config-example.yaml (+19 -8)
📝 config.go (+27 -1)
📝 integration/auth_oidc_test.go (+10 -6)
📝 integration_test/etc/alt-config.dump.gold.yaml (+2 -0)
📝 integration_test/etc/alt-env-config.dump.gold.yaml (+2 -0)
📝 integration_test/etc/config.dump.gold.yaml (+2 -0)
📝 oidc.go (+20 -4)

📄 Description

This commit adds a default OpenID Connect expiry to 180d to align with Tailscale SaaS (previously infinite or based on token expiry).

In addition, it adds an option use the expiry time from the Token sent by the OpenID provider. This will typically cause really short expiry and you should only turn on this option if you know what you are desiring.

This fixes #1176.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1191 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 1/31/2023 **Status:** ✅ Merged **Merged:** 1/31/2023 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `node-expiry` --- ### 📝 Commits (1) - [`07940ec`](https://github.com/juanfont/headscale/commit/07940ecc696e6f0fbae4ffb9cf96e0550a99010c) Set OpenID Connect Expiry ### 📊 Changes **10 files changed** (+88 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test-integration-v2-TestOIDCExpireNodesBasedOnTokenExpiry.yaml` (+2 -2) 📝 `CHANGELOG.md` (+3 -0) 📝 `cmd/gh-action-integration-generator/main.go` (+1 -1) 📝 `config-example.yaml` (+19 -8) 📝 `config.go` (+27 -1) 📝 `integration/auth_oidc_test.go` (+10 -6) 📝 `integration_test/etc/alt-config.dump.gold.yaml` (+2 -0) 📝 `integration_test/etc/alt-env-config.dump.gold.yaml` (+2 -0) 📝 `integration_test/etc/config.dump.gold.yaml` (+2 -0) 📝 `oidc.go` (+20 -4) </details> ### 📄 Description This commit adds a default OpenID Connect expiry to `180d` to align with Tailscale SaaS (previously infinite or based on token expiry). In addition, it adds an option use the expiry time from the Token sent by the OpenID provider. This will typically cause really short expiry and you should only turn on this option if you know what you are desiring. This fixes #1176. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:19:00 +01:00
adam closed this issue 2025-12-29 03:19:00 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1950
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?