starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1180] [CLOSED] Do not show IsPrimary field as false in exit nodes #1940

New Issue
Closed
opened 2025-12-29 03:18:58 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:18:58 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1180
Author: @juanfont
Created: 1/29/2023
Status: ❌ Closed

Base: main ← Head: do-not-show-primary-exit

📝 Commits (3)

  • 66007d8 Do not show IsPrimary field as false in exit nodes
  • b542f52 Enable both exit node routes (IPv4 and IPv6) at the same time.
  • 5aef8eb Update tests

📊 Changes

5 files changed (+58 additions, -24 deletions)

View changed files

📝 CHANGELOG.md (+8 -2)
📝 cmd/headscale/cli/routes.go (+16 -1)
📝 machine.go (+2 -2)
📝 routes.go (+8 -1)
📝 routes_test.go (+24 -18)

📄 Description

Currently exit routes are shown as 'False' in the primary column of the CLI - which is not relevant for exit nodes.

This PR fixes that.

Also, adds a missing entry in the changelog.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1180 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 1/29/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `do-not-show-primary-exit` --- ### 📝 Commits (3) - [`66007d8`](https://github.com/juanfont/headscale/commit/66007d845512aa539f887d081420ebd68e12d833) Do not show IsPrimary field as false in exit nodes - [`b542f52`](https://github.com/juanfont/headscale/commit/b542f528f126fd91df4229fa4a3a75d847db3215) Enable both exit node routes (IPv4 and IPv6) at the same time. - [`5aef8eb`](https://github.com/juanfont/headscale/commit/5aef8ebccb7d9169276dbea96f46c8a05478c9a9) Update tests ### 📊 Changes **5 files changed** (+58 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+8 -2) 📝 `cmd/headscale/cli/routes.go` (+16 -1) 📝 `machine.go` (+2 -2) 📝 `routes.go` (+8 -1) 📝 `routes_test.go` (+24 -18) </details> ### 📄 Description Currently exit routes are shown as 'False' in the primary column of the CLI - which is not relevant for exit nodes. This PR fixes that. Also, adds a missing entry in the changelog. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:18:58 +01:00
adam closed this issue 2025-12-29 03:18:58 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1940
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?