starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1159] [MERGED] Enable both exit routes at the same time #1924

New Issue
Closed
opened 2025-12-29 03:18:53 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:18:53 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1159
Author: @juanfont
Created: 1/22/2023
Status: ✅ Merged
Merged: 1/29/2023
Merged by: @juanfont

Base: main ← Head: enable-both-exit-routers

📝 Commits (2)

  • 423f53c Enable both exit node routes (IPv4 and IPv6) at the same time.
  • e8fe381 Update tests

📊 Changes

3 files changed (+34 additions, -21 deletions)

View changed files

📝 machine.go (+2 -2)
📝 routes.go (+8 -1)
📝 routes_test.go (+24 -18)

📄 Description

As indicated by @bradfitz (thanks!!) at https://github.com/juanfont/headscale/issues/804#issuecomment-1399314002, both routes (IPv4 and IPv6) need to enabled for an exit node to be considered.

This PR makes sure that when enabling 0.0.0.0/0 or ::/0 the other gets enabled too.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1159 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 1/22/2023 **Status:** ✅ Merged **Merged:** 1/29/2023 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `enable-both-exit-routers` --- ### 📝 Commits (2) - [`423f53c`](https://github.com/juanfont/headscale/commit/423f53c2af6df9ee4e0ca86562588977be49c9ba) Enable both exit node routes (IPv4 and IPv6) at the same time. - [`e8fe381`](https://github.com/juanfont/headscale/commit/e8fe381503ae958d95492fd367e1363d458b7f5b) Update tests ### 📊 Changes **3 files changed** (+34 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `machine.go` (+2 -2) 📝 `routes.go` (+8 -1) 📝 `routes_test.go` (+24 -18) </details> ### 📄 Description As indicated by @bradfitz (thanks!!) at https://github.com/juanfont/headscale/issues/804#issuecomment-1399314002, both routes (IPv4 and IPv6) need to enabled for an exit node to be considered. This PR makes sure that when enabling 0.0.0.0/0 or ::/0 the other gets enabled too. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:18:53 +01:00
adam closed this issue 2025-12-29 03:18:53 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1924
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?