starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1147] [MERGED] Migrate DB: rename table is plural #1916

New Issue
Closed
opened 2025-12-29 03:18:52 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:18:52 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1147
Author: @kradalby
Created: 1/18/2023
Status: ✅ Merged
Merged: 1/19/2023
Merged by: @kradalby

Base: main ← Head: rename-namespace-to-user-migration-fix

📝 Commits (2)

  • 9ffe5ff Migrate DB: rename table is plural, order matters
  • 90241cf Update changelog, more explicit backup note

📊 Changes

2 files changed (+8 additions, -7 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 db.go (+7 -7)

📄 Description

The calls to AutoMigrate to other classes that refer to users will
create the table and it will break, it needs to be done before
everything else.

Signed-off-by: Kristoffer Dalby kristoffer@tailscale.com

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1147 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 1/18/2023 **Status:** ✅ Merged **Merged:** 1/19/2023 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `rename-namespace-to-user-migration-fix` --- ### 📝 Commits (2) - [`9ffe5ff`](https://github.com/juanfont/headscale/commit/9ffe5ffc8b3543a14b4c3826d5012f9b17e9a812) Migrate DB: rename table is plural, order matters - [`90241cf`](https://github.com/juanfont/headscale/commit/90241cf7d2fc7ebb9df22a0ff8e48bb0d0b7b3e4) Update changelog, more explicit backup note ### 📊 Changes **2 files changed** (+8 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `db.go` (+7 -7) </details> ### 📄 Description The calls to AutoMigrate to other classes that refer to users will create the table and it will break, it needs to be done before everything else. Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:18:52 +01:00
adam closed this issue 2025-12-29 03:18:52 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1916
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?