starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 12:20:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1127] [MERGED] oidc: allow reading the client secret from a file #1899

New Issue
Closed
opened 2025-12-29 03:18:41 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:18:41 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1127
Author: @motiejus
Created: 1/10/2023
Status: ✅ Merged
Merged: 1/14/2023
Merged by: @kradalby

Base: main ← Head: oidc-client-secret-file

📝 Commits (1)

  • d57b3b0 oidc: allow reading the client secret from a file

📊 Changes

6 files changed (+59 additions, -8 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 config-example.yaml (+5 -0)
📝 config.go (+17 -1)
📝 docs/oidc.md (+4 -0)
📝 integration/auth_oidc_test.go (+3 -1)
📝 integration/hsic/hsic.go (+29 -6)

📄 Description

Currently the most "secret" way to specify the oidc client secret is via an environment variable OIDC_CLIENT_SECRET, which is problematic1. Lets allow reading oidc client secret from a file. For extra convenience the path to the secret will resolve the environment variables.

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1127 **Author:** [@motiejus](https://github.com/motiejus) **Created:** 1/10/2023 **Status:** ✅ Merged **Merged:** 1/14/2023 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `oidc-client-secret-file` --- ### 📝 Commits (1) - [`d57b3b0`](https://github.com/juanfont/headscale/commit/d57b3b01e57eed88cdd197888da2d25a1f343318) oidc: allow reading the client secret from a file ### 📊 Changes **6 files changed** (+59 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `config-example.yaml` (+5 -0) 📝 `config.go` (+17 -1) 📝 `docs/oidc.md` (+4 -0) 📝 `integration/auth_oidc_test.go` (+3 -1) 📝 `integration/hsic/hsic.go` (+29 -6) </details> ### 📄 Description Currently the most "secret" way to specify the oidc client secret is via an environment variable `OIDC_CLIENT_SECRET`, which is problematic[1]. Lets allow reading oidc client secret from a file. For extra convenience the path to the secret will resolve the environment variables. [1]: https://systemd.io/CREDENTIALS/ - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [x] added integration tests - [x] updated documentation if needed - [x] updated CHANGELOG.md --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:18:41 +01:00
adam closed this issue 2025-12-29 03:18:41 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1899
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?