starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1098] [MERGED] Remove ephemeral on logout #1876

New Issue
Closed
opened 2025-12-29 02:32:05 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:32:05 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1098
Author: @juanfont
Created: 12/27/2022
Status: ✅ Merged
Merged: 1/5/2023
Merged by: @juanfont

Base: main ← Head: remove-ephemeral-on-logout

📝 Commits (5)

  • 11e6a8a Add isEphemeral() method to Machine
  • fb161d6 Delete ephemeral machines on logout
  • 0c25ef9 Added integration tests for ephemeral nodes
  • 8b68909 Preload AuthKey in machine getters
  • aef2ade Update CHANGELOG.md

📊 Changes

9 files changed (+146 additions, -14 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 app.go (+1 -2)
📝 integration/control.go (+1 -1)
📝 integration/general_test.go (+104 -1)
📝 integration/hsic/hsic.go (+10 -1)
📝 integration/scenario.go (+3 -3)
📝 integration/scenario_test.go (+2 -2)
📝 machine.go (+10 -4)
📝 protocol_common.go (+14 -0)

📄 Description

This PR implements #1087, to better adhere to a change on how ephemeral nodes behave on logout in the SaaS https://tailscale.com/blog/ephemeral-logout/.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1098 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 12/27/2022 **Status:** ✅ Merged **Merged:** 1/5/2023 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `remove-ephemeral-on-logout` --- ### 📝 Commits (5) - [`11e6a8a`](https://github.com/juanfont/headscale/commit/11e6a8a4c1963ec67f28edfdd9dd6ffec480c68a) Add isEphemeral() method to Machine - [`fb161d6`](https://github.com/juanfont/headscale/commit/fb161d6a4bdeb7e2f7c7f31c3432c4b257225568) Delete ephemeral machines on logout - [`0c25ef9`](https://github.com/juanfont/headscale/commit/0c25ef97a2cd2a1281e033150e9ac292a6e99fd4) Added integration tests for ephemeral nodes - [`8b68909`](https://github.com/juanfont/headscale/commit/8b689092cdbc4f36d6c77b1a1cdeaa000f47ceee) Preload AuthKey in machine getters - [`aef2ade`](https://github.com/juanfont/headscale/commit/aef2adeccd2c31427f49912b6c911c21d648e0cd) Update CHANGELOG.md ### 📊 Changes **9 files changed** (+146 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `app.go` (+1 -2) 📝 `integration/control.go` (+1 -1) 📝 `integration/general_test.go` (+104 -1) 📝 `integration/hsic/hsic.go` (+10 -1) 📝 `integration/scenario.go` (+3 -3) 📝 `integration/scenario_test.go` (+2 -2) 📝 `machine.go` (+10 -4) 📝 `protocol_common.go` (+14 -0) </details> ### 📄 Description This PR implements #1087, to better adhere to a change on how ephemeral nodes behave on logout in the SaaS https://tailscale.com/blog/ephemeral-logout/. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:32:05 +01:00
adam closed this issue 2025-12-29 02:32:05 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1876
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?