starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1067] [MERGED] OIDC: Expire machines/nodes after token expiry #1852

New Issue
Closed
opened 2025-12-29 02:31:58 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:58 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1067
Author: @evenh
Created: 12/15/2022
Status: ✅ Merged
Merged: 1/4/2023
Merged by: @kradalby

Base: main ← Head: oidc-expire-nodes

📝 Commits (5)

  • a4d2d2f add expiration from OIDC token to machine
  • f687b3c expire machines after db expiry
  • bcae0a3 oidc: add test for expiring nodes after token expiration
  • 4466b53 oidc: add basic docs
  • e1d9404 oidc: update changelog

📊 Changes

10 files changed (+342 additions, -30 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 app.go (+57 -0)
📝 cmd/headscale/cli/mockoidc.go (+12 -1)
📝 docs/README.md (+1 -0)
➕ docs/oidc.md (+137 -0)
📝 grpcv1.go (+1 -0)
📝 integration/auth_oidc_test.go (+107 -28)
📝 integration/dockertestutil/network.go (+18 -0)
📝 machine.go (+5 -0)
📝 oidc.go (+3 -1)

📄 Description

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

expires-soon
expired

This PR seems to work (at least headscale mockoidc and Azure AD) for my use case.

Fixes #935.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1067 **Author:** [@evenh](https://github.com/evenh) **Created:** 12/15/2022 **Status:** ✅ Merged **Merged:** 1/4/2023 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `oidc-expire-nodes` --- ### 📝 Commits (5) - [`a4d2d2f`](https://github.com/juanfont/headscale/commit/a4d2d2f913a5de2940eb93062ab30495e04fb799) add expiration from OIDC token to machine - [`f687b3c`](https://github.com/juanfont/headscale/commit/f687b3c99ff41f69af0b47b85d59c3e8f6a0ec89) expire machines after db expiry - [`bcae0a3`](https://github.com/juanfont/headscale/commit/bcae0a3225e52039c9137fa2e7025552098ea455) oidc: add test for expiring nodes after token expiration - [`4466b53`](https://github.com/juanfont/headscale/commit/4466b5354521e6267346f7f59d5ace3f71083d3b) oidc: add basic docs - [`e1d9404`](https://github.com/juanfont/headscale/commit/e1d940450e07bab6723d2dc4806cd63afaf8fdbc) oidc: update changelog ### 📊 Changes **10 files changed** (+342 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `app.go` (+57 -0) 📝 `cmd/headscale/cli/mockoidc.go` (+12 -1) 📝 `docs/README.md` (+1 -0) ➕ `docs/oidc.md` (+137 -0) 📝 `grpcv1.go` (+1 -0) 📝 `integration/auth_oidc_test.go` (+107 -28) 📝 `integration/dockertestutil/network.go` (+18 -0) 📝 `machine.go` (+5 -0) 📝 `oidc.go` (+3 -1) </details> ### 📄 Description <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [x] added integration tests - [x] updated documentation if needed - [x] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> ![expires-soon](https://user-images.githubusercontent.com/2701536/207783887-6f325fc1-6717-4102-a267-65678b4673e8.png) ![expired](https://user-images.githubusercontent.com/2701536/207783909-4111b8c8-27f0-4053-81e0-b1ca0fb8b781.png) This PR seems to work (at least `headscale mockoidc` and Azure AD) for my use case. Fixes #935. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:58 +01:00
adam closed this issue 2025-12-29 02:31:58 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1852
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?