starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-13 12:50:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1062] [MERGED] Report if a machine is online in CLI more accurately #1848

New Issue
Closed
opened 2025-12-29 02:31:57 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:57 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1062
Author: @juanfont
Created: 12/13/2022
Status: ✅ Merged
Merged: 12/15/2022
Merged by: @kradalby

Base: main ← Head: more-accurate-online

📝 Commits (5)

  • 00e52a3 Include online field in proto for machine
  • 6588a9c Refresh autogenerated grpc stuff
  • c22e23c Show online in CLI & API when isOnline() reports so
  • ea6b0c1 Update changelog
  • 597977b Merge branch 'main' into more-accurate-online

📊 Changes

6 files changed (+101 additions, -88 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 cmd/headscale/cli/nodes.go (+1 -3)
📝 gen/go/headscale/v1/machine.pb.go (+94 -85)
📝 gen/openapiv2/headscale/v1/headscale.swagger.json (+3 -0)
📝 machine.go (+1 -0)
📝 proto/headscale/v1/machine.proto (+1 -0)

📄 Description

Until now, we were reporting in the CLI if a machine is online if LastSeen was before 5 minutes, now we will show if machine.isOnline().

This method is currently based on the keep alive time, but hopefully in the future we will be able to report if the machine is really connected to headscale.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1062 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 12/13/2022 **Status:** ✅ Merged **Merged:** 12/15/2022 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `more-accurate-online` --- ### 📝 Commits (5) - [`00e52a3`](https://github.com/juanfont/headscale/commit/00e52a3827801cf3867ce6b8aa63072c9f8b5cfb) Include online field in proto for machine - [`6588a9c`](https://github.com/juanfont/headscale/commit/6588a9c7c3dd5befe54787632e57899d4a04a8f3) Refresh autogenerated grpc stuff - [`c22e23c`](https://github.com/juanfont/headscale/commit/c22e23c683e0b8c78ef59942e183e355e646eb97) Show online in CLI & API when isOnline() reports so - [`ea6b0c1`](https://github.com/juanfont/headscale/commit/ea6b0c122f8710b66dd7927097e04d1042a5efd1) Update changelog - [`597977b`](https://github.com/juanfont/headscale/commit/597977b72acd408bfd4b0b5c07b24e89e87273c7) Merge branch 'main' into more-accurate-online ### 📊 Changes **6 files changed** (+101 additions, -88 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `cmd/headscale/cli/nodes.go` (+1 -3) 📝 `gen/go/headscale/v1/machine.pb.go` (+94 -85) 📝 `gen/openapiv2/headscale/v1/headscale.swagger.json` (+3 -0) 📝 `machine.go` (+1 -0) 📝 `proto/headscale/v1/machine.proto` (+1 -0) </details> ### 📄 Description Until now, we were reporting in the CLI if a machine is online if LastSeen was before 5 minutes, now we will show if `machine.isOnline()`. This method is currently based on the keep alive time, but hopefully in the future we will be able to report if the machine is really connected to headscale. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:57 +01:00
adam closed this issue 2025-12-29 02:31:57 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1848
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?