starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1035] [MERGED] add the possibility for custom DNS records #1831

New Issue
Closed
opened 2025-12-29 02:31:53 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:53 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1035
Author: @christian-heusel
Created: 12/2/2022
Status: ✅ Merged
Merged: 1/1/2023
Merged by: @juanfont

Base: main ← Head: main

📝 Commits (5)

  • 7abc911 add the possibility for custom DNS records
  • f9a099f document how to add new DNS records via extra_records
  • 7aa164a enumerate the config
  • c5b38c2 add changelog entry
  • 02fda72 fix spelling mistakes

📊 Changes

5 files changed (+110 additions, -0 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 config-example.yaml (+11 -0)
📝 config.go (+14 -0)
📝 docs/README.md (+1 -0)
➕ docs/dns-records.md (+83 -0)

📄 Description

This PR adds the code of b9f05fca8d but patched into the correct file as the code location now has been updated.
I have run the latest headscale for the last month with this change and it works great! 🥳

My usecase is serving some internal applications such as grafana.vpn.my.domain and a have reverse proxy on the host that correctly maps the requests 👍🏻

I would be willing to add documentation, tests and more if needed, just let me know what you think of merging this before I invest the work ^^

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

related to https://github.com/juanfont/headscale/issues/762
Also notifying @madjam002 since the code was originally from him 😊

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1035 **Author:** [@christian-heusel](https://github.com/christian-heusel) **Created:** 12/2/2022 **Status:** ✅ Merged **Merged:** 1/1/2023 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (5) - [`7abc911`](https://github.com/juanfont/headscale/commit/7abc9118bcc1a57d1a2ce49f49ad56b878e5f6e6) add the possibility for custom DNS records - [`f9a099f`](https://github.com/juanfont/headscale/commit/f9a099fc4a46fc9ea3a4c65e1fb5140b09457a60) document how to add new DNS records via extra_records - [`7aa164a`](https://github.com/juanfont/headscale/commit/7aa164a02bae6301cdf60dbd40403e2bb15eadc1) enumerate the config - [`c5b38c2`](https://github.com/juanfont/headscale/commit/c5b38c254bf263aac4f93d391c61bda9713e51ba) add changelog entry - [`02fda72`](https://github.com/juanfont/headscale/commit/02fda72c56b52433889bf7a84a44dc425005872f) fix spelling mistakes ### 📊 Changes **5 files changed** (+110 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `config-example.yaml` (+11 -0) 📝 `config.go` (+14 -0) 📝 `docs/README.md` (+1 -0) ➕ `docs/dns-records.md` (+83 -0) </details> ### 📄 Description This PR adds the code of https://github.com/madjam002/headscale/commit/b9f05fca8d7fcc246b44a0495587b9de1582049c but patched into the correct file as the code location now has been updated. I have run the latest headscale for the last month with this change and it works great! 🥳 My usecase is serving some internal applications such as `grafana.vpn.my.domain` and a have reverse proxy on the host that correctly maps the requests 👍🏻 I would be willing to add documentation, tests and more if needed, just let me know what you think of merging this before I invest the work ^^ <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [x] updated documentation if needed - [x] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> related to https://github.com/juanfont/headscale/issues/762 Also notifying @madjam002 since the code was originally from him 😊 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:53 +01:00
adam closed this issue 2025-12-29 02:31:53 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1831
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?