starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #985] [MERGED] WaitForReady in web auth flow integration tests outside up goroutine #1794

New Issue
Closed
opened 2025-12-29 02:31:43 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:43 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/985
Author: @juanfont
Created: 11/19/2022
Status: ✅ Merged
Merged: 11/19/2022
Merged by: @juanfont

Base: main ← Head: waitts-outside-goroutine

📝 Commits (1)

  • f026847 Move TS WaitForReady outside up goroutine

📊 Changes

1 file changed (+5 additions, -5 deletions)

View changed files

📝 integration/auth_web_flow_test.go (+5 -5)

📄 Description

This minor PR runs the WaitForReady outside the up goroutine, to fix intermittent issues when running the integration tests.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/985 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 11/19/2022 **Status:** ✅ Merged **Merged:** 11/19/2022 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `waitts-outside-goroutine` --- ### 📝 Commits (1) - [`f026847`](https://github.com/juanfont/headscale/commit/f0268471a6afbe1eae1a730933a851a4081a1958) Move TS WaitForReady outside up goroutine ### 📊 Changes **1 file changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `integration/auth_web_flow_test.go` (+5 -5) </details> ### 📄 Description This minor PR runs the WaitForReady outside the up goroutine, to fix intermittent issues when running the integration tests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:43 +01:00
adam closed this issue 2025-12-29 02:31:43 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1794
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?