starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #971] [MERGED] Fix AuthURL on machine expiration when using OIDC #1780

New Issue
Closed
opened 2025-12-29 02:31:40 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:40 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/971
Author: @juanfont
Created: 11/15/2022
Status: ✅ Merged
Merged: 11/15/2022
Merged by: @juanfont

Base: main ← Head: troubleshoot-oidc-windows

📝 Commits (4)

  • b673d6f Added more debug messages in OIDC registration
  • 0cc6f07 Added more logging
  • 986cf5b Do not strip nodekey prefix on handle expired
  • c76fb76 Updated changelog

📊 Changes

3 files changed (+9 additions, -3 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 oidc.go (+5 -2)
📝 protocol_common.go (+3 -1)

📄 Description

We were sending the stripped nodekey on the AuthURL when using OIDC on nodekey expired.

This PR fixes it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/971 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 11/15/2022 **Status:** ✅ Merged **Merged:** 11/15/2022 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `troubleshoot-oidc-windows` --- ### 📝 Commits (4) - [`b673d6f`](https://github.com/juanfont/headscale/commit/b673d6f0b65e25671f5986c38dbbdbf0cc1fb887) Added more debug messages in OIDC registration - [`0cc6f07`](https://github.com/juanfont/headscale/commit/0cc6f0750300f9db0a0466a3cbe90730eb3aba8d) Added more logging - [`986cf5b`](https://github.com/juanfont/headscale/commit/986cf5b69f4efc0de70ebdf40c8e09c1443f6ab7) Do not strip nodekey prefix on handle expired - [`c76fb76`](https://github.com/juanfont/headscale/commit/c76fb76b4ea04f0bb36e1874cdbc2b50ec78a27f) Updated changelog ### 📊 Changes **3 files changed** (+9 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `oidc.go` (+5 -2) 📝 `protocol_common.go` (+3 -1) </details> ### 📄 Description We were sending the stripped nodekey on the AuthURL when using OIDC on nodekey expired. This PR fixes it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:40 +01:00
adam closed this issue 2025-12-29 02:31:40 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1780
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?