starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #967] [CLOSED] Add enumeration missing in the ACL rule filter #1778

New Issue
Closed
opened 2025-12-29 02:31:39 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:39 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/967
Author: @gps949
Created: 11/15/2022
Status: ❌ Closed

Base: main ← Head: patch-1

📝 Commits (2)

  • 89f99af Add enumeration missing in the ACL rule filter
  • 5338acb Merge branch 'main' into patch-1

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 machine.go (+6 -0)

📄 Description

Signed-off-by: Chenyang Gao gps949@outlook.com

In the ACL rule filter, it enumerates machine<->peer, machine<->"*", "*"<->"*", but only "*"->"peer".
Need to added the case matching for peer->"*"

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/967 **Author:** [@gps949](https://github.com/gps949) **Created:** 11/15/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (2) - [`89f99af`](https://github.com/juanfont/headscale/commit/89f99af6d949a3fcefeac695d0489275e00177d2) Add enumeration missing in the ACL rule filter - [`5338acb`](https://github.com/juanfont/headscale/commit/5338acb4b899e2d245565b0807361ba7e83c644a) Merge branch 'main' into patch-1 ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `machine.go` (+6 -0) </details> ### 📄 Description Signed-off-by: Chenyang Gao <gps949@outlook.com> In the ACL rule filter, it enumerates machine<->peer, machine<->"\*", "\*"<->"\*", but only "\*"->"peer". Need to added the case matching for peer->"\*" <!-- Please tick if the following things apply. You… --> - [x] read the [CONTRIBUTING guidelines](README.md#contributing) - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md <!-- If applicable, please reference the issue using `Fixes #XXX` and add tests to cover your new code. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:39 +01:00
adam closed this issue 2025-12-29 02:31:39 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1778
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?