starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #960] [MERGED] OIDC code cleanup and harmonize with regular web auth #1771

New Issue
Closed
opened 2025-12-29 02:31:38 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:38 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/960
Author: @juanfont
Created: 11/14/2022
Status: ✅ Merged
Merged: 11/14/2022
Merged by: @juanfont

Base: main ← Head: oidc-cleanup

📝 Commits (2)

  • 4034fbc OIDC code cleanup and harmonize with regular web auth
  • 613d294 Return the correct error on cache miss

📊 Changes

1 file changed (+64 additions, -29 deletions)

View changed files

📝 oidc.go (+64 -29)

📄 Description

This PR improves the handling on NodeKeys in the OIDC auth flow + adds more logging and checks.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/960 **Author:** [@juanfont](https://github.com/juanfont) **Created:** 11/14/2022 **Status:** ✅ Merged **Merged:** 11/14/2022 **Merged by:** [@juanfont](https://github.com/juanfont) **Base:** `main` ← **Head:** `oidc-cleanup` --- ### 📝 Commits (2) - [`4034fbc`](https://github.com/juanfont/headscale/commit/4034fbc6e9fc46f833ebfc3b450a1b190a39ab1e) OIDC code cleanup and harmonize with regular web auth - [`613d294`](https://github.com/juanfont/headscale/commit/613d29478db2d146e320bc56a2092b3e5cf68fd6) Return the correct error on cache miss ### 📊 Changes **1 file changed** (+64 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `oidc.go` (+64 -29) </details> ### 📄 Description This PR improves the handling on NodeKeys in the OIDC auth flow + adds more logging and checks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:38 +01:00
adam closed this issue 2025-12-29 02:31:38 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1771
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?